Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#15751 closed enhancement (fixed)

GraphicsMagick: Add variants for different quantum depths

Reported by: gallafent Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc:
Port:

Description

By adding the following lines to the portfile, the quantum depth of the graphicsmagick build may be set, allowing it to output images with a higher bit-depth than eight!

variant quantumdepth8 conflicts quantumdepth16 quantumdepth32 {
				configure.args-append --with-quantum-depth=8
}

variant quantumdepth16 conflicts quantumdepth8 quantumdepth32 {
				configure.args-append --with-quantum-depth=16
}

variant quantumdepth32 conflicts quantumdepth8 quantumdepth16 {
				configure.args-append --with-quantum-depth=32
}

Change History (5)

comment:1 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Milestone: Port Enhancements
Summary: Additional variants (quantum depth configuration option) for graphicsmagickGraphicsMagick: Add variants for different quantum depths

Perhaps the variants could be named and written like they are in ImageMagick instead of inventing new names for GraphicsMagick.

In ImageMagick the default quantum depth is 16. Is it 8 in GraphicsMagick?

comment:2 Changed 16 years ago by gallafent

Yes, absolutely agree, revised version below.

The default quantum depth is indeed 8 in GraphicsMagick! This is mentioned in http://www.graphicsmagick.org/www/INSTALL-unix.html

Do you think we should add a "default_variants +q8" here to force this to remain a constant in the macport, or leave the default to follow GraphicsMagick's default, even if that changes in the future?

variant q8 conflicts q16 q32 description {Use 8 bits per pixel quantum (default)} {
				configure.args-append --with-quantum-depth=8
}

variant q16 conflicts q8 q32 description {Use 16 bits per pixel quantum} {
				configure.args-append --with-quantum-depth=16
}

variant q32 conflicts q8 q16 description {Use 32 bits per pixel quantum} {
				configure.args-append --with-quantum-depth=32
}

comment:3 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:4 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thanks, I added the three variants in r39317, along with the appropriate default_variants statement to ensure that q8 is set to the default, unless the user has already selected something else. This matches what the ImageMagick port does. If GraphicsMagick ever changes its default pixel quantum depth, then the selection of the default variant should be modified accordingly.

comment:5 Changed 16 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.