freeciv doesn't compile on 10.4 (patch included)

[simon@…]

Hi,

I just tried updating freeciv to version 2.1.5 and it failed with the following error:

In file included from graphics.c:31:
/opt/local/include/SDL/SDL_syswm.h:55:22: error: X11/Xlib.h: No such file or directory

It looks it's missing the include path to /usr/X11R6/include, the following patch works for me:

--- a/dports/games/freeciv/Portfile
+++ b/dports/games/freeciv/Portfile
@@ -47,3 +47,5 @@ configure.args        \
     --with-libiconv-prefix=${prefix} \
     --with-sdl-prefix=${prefix} \
     --mandir=${prefix}/share/man
+
+configure.cflags-append "-I/usr/X11R6/include"

Thanks,

Simon

[jmroot (Joshua Root)]

Shouldn't it rather be:

--- a/dports/games/freeciv/Portfile
+++ b/dports/games/freeciv/Portfile
@@ -47,3 +47,5 @@ configure.args        \
     --with-libiconv-prefix=${prefix} \
     --with-sdl-prefix=${prefix} \
     --mandir=${prefix}/share/man
+
+configure.cppflags-append -I${x11prefix}/include

But why does freeciv (as opposed to freeciv-x11) need the X includes at all?

[rhwood@…]

freeciv does not require X11, but libsdl does. Can you please post the output of "otool -L /opt/local/bin/civclient" here?

[simon@…]

Sure, here it is:

/opt/local/bin/civclient:
        /opt/local/lib/libintl.8.dylib (compatibility version 9.0.0, current version 9.2.0)
        /opt/local/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
        /opt/local/lib/libSDL_image-1.2.0.dylib (compatibility version 2.0.0, current version 2.5.0)
        /opt/local/lib/libSDL-1.2.0.dylib (compatibility version 12.0.0, current version 12.2.0)
        /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 11.0.0)
        /opt/local/lib/libfreetype.6.dylib (compatibility version 10.0.0, current version 10.17.0)
        /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.3)
        /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 18.0.0)
        /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices (compatibility version 1.0.0, current version 22.0.0)
        /opt/local/lib/libSDL_mixer-1.2.0.dylib (compatibility version 3.0.0, current version 3.6.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 88.3.10)

[nox@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Does this problem persist with freeciv 2.1.8?

[blb@…]

Weird, my libsdl isn't linked against X11 at all, and I didn't use +no_x11...does libsdl build against X11 on 10.4 maybe but not 10.5? My libSDL.dylib is linked against a bunch of frameworks but no X11; also, when I run civclient (the latest 2.1.9), I see

2: Using Video Output: Quartz
2009-03-29 20:54:20.821 civclient[73446:10b] Warning once: This application, or a library it uses, is using NSQuickDrawView, which has been deprecated. Apps should cease use of QuickDraw and move to Quartz.

[(none)]

Milestone Port Bugs deleted

[tobypeterson]

Nothing from reporter in 14 months, and given that we no longer have a separate x11prefix, this is probably resolved.