umit

[luis.kop@…]

Hi all.

I'm developer of Umit Project and i'm here to request that you test and give suggestions to fix and add our Portfile to our servers, if is it possible.

I hope your feedback.

Thanks for all.

[luis.kop@…]

Cc Me!

[raimue (Rainer Müller)]

patch-base.diff hardcodes the prefix /opt/local into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace.

You already added a reinplace for ${prefix} in post-destroot {}, but I think it would be more appropriate to do this in post-patch {}.

[luis.kop@…]

Replying to raimue@macports.org:

patch-base.diff hardcodes the prefix /opt/local into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace.

You already added a reinplace for ${prefix} in post-destroot {}, but I think it would be more appropriate to do this in post-patch {}.

Hi. Thanks for the comment. About the patch-base it's true, it's hardcode. But how hack the file during the installation. Using sed?

About replace post-destroot by post-patch it's not a good idea. It didn't work. Is it mandatory in post-patch?

[raimue (Rainer Müller)]

Use this in the patch file:

CONFIG_DIR = "__PREFIX__/share/umit/config"
...

And use this post-patch:

post-patch {
    reinplace "s|__PREFIX__|${prefix}|g" ${worksrcpath}/umitCore/BasePaths.py
}

I don't think you need another reinplace in post-destroot.

[luis.kop@…]

yeah. It's true.

You're right. I copy this from other Portfile and I didn't understand. Now I understand and I fix it. The files are commited. What do you think about that? Is it ok, now? :)

[raimue (Rainer Müller)]

Committed in r38112.

[(none)]

Milestone Port Requests deleted