PHP4 path error for apache2

[contact1@…]

There is an unknown variable, ${apache2_path}, for the apache2 variant of php4. I am building on MacOS X 10.3.3. Correcting that to ${prefix}/apache2 fixes the issue. Attached is a patch for the issue.

-albert

--- Portfile.orig       Wed Mar 17 09:01:21 2004
+++ Portfile    Wed Mar 17 09:01:58 2004
@@ -86,7 +86,7 @@
 
 variant apache2 {
        depends_lib-append      path:${prefix}/apache2/bin/apxs:apache2
-       configure.args-append   --with-apxs2=${apache2_path}/bin/apxs
+       configure.args-append   --with-apxs2=${prefix}/apache2/bin/apxs
 }
 
 variant crypt {

[contact1@…]

patch to fix apache2 path issues

[contact1@…]

I'd like to propose a different solution, as there are multiple ${apache2_path} variables within the file. Rather, this variable could be set at the beginning of the file. Also, there is an ${apache_path} which should be ${apache2_path}. Attached is a patch.

-albert

--- ../../../../darwinports/dports/www/php4/Portfile    Wed Mar 17 10:09:53 2004
+++ Portfile Wed Mar 17 10:10:50 2004
@@ -29,6 +29,8 @@
 
 patchfiles  patch-configure
 
+set apache2_path ${prefix}/apache2
+
 depends_lib lib:libiconv.2:libiconv \
        lib:libexpat.0.4:expat  \
        lib:libintl:gettext \
@@ -184,7 +186,7 @@
 
      if { [variant_isset apache2] } {
        file mkdir ${destroot}${apache2_path}/modules
-       xinstall -m 755 ${worksrcpath}/libs/libphp4.so ${destroot}${apache_path}/modules/
+       xinstall -m 755 ${worksrcpath}/libs/libphp4.so ${destroot}${apache2_path}/modules/
        file mkdir ${destroot}${apache2_path}/conf/extras-conf
        xinstall -o root -m 755 -c  ${portpath}/files/mod_php.conf ${destroot}${apache2_path}/conf/extras-conf
      } 

[toby@…]

This is actually bit different now, since I changed apache2 to install into a sane directory structure (FreeBSD layout, prefix=${prefix}). So apache just goes into $prefix/bin/apachectl (etc).

[bchesneau@…]

Just committed new php4 port. Thanks :)