Opened 16 years ago

Closed 16 years ago

#16452 closed enhancement (fixed)

apr: version bump plus configure changes

Reported by: wsiegrist@… Owned by: danielluke (Daniel J. Luke)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: blair (Blair Zajac)
Port: apr

Description

Attached is a patch for apr to bump to v1.3.3 as well as apply some improvements for darwin_9:

  • allow use of sendfile now that APR can handle darwin's sendfile
  • use flocks for locking
  • dont use kqueue or poll

Attachments (1)

apr.patch (1.1 KB) - added by wsiegrist@… 16 years ago.
Patch for apr Portfile

Download all attachments as: .zip

Change History (10)

Changed 16 years ago by wsiegrist@…

Attachment: apr.patch added

Patch for apr Portfile

comment:1 Changed 16 years ago by wsiegrist@…

Port: apr added

comment:2 Changed 16 years ago by danielluke (Daniel J. Luke)

Status: newassigned

I should get a chance to look at this and do some testing in the next couple of days.

comment:3 Changed 16 years ago by danielluke (Daniel J. Luke)

Can you explain why we want to override the configure selection (for in favor of flock and no kqueue)?

Thanks.

comment:4 Changed 16 years ago by blair (Blair Zajac)

Yes, it definitely would be good to know from an Apple employee why to have APR use those defaults.

One reason alone not to use flock() is that flock() doesn't work over NFS, while fcntl() based locks do.

Subversion needs locking, so this could prevent Subversion fsfs repositories from working correctly on NFS.

comment:5 Changed 16 years ago by blair (Blair Zajac)

Cc: blair@… added

Adding myself to the cc list.

comment:6 Changed 16 years ago by danielluke (Daniel J. Luke)

1.3.3 committed without the darwin 9 platform changes, pending a response for why we might want things set that way.

comment:7 Changed 16 years ago by wsiegrist@…

Flock is a little faster, but maybe it should be a variant since it doesnt work on NFS. The use of select instead of kqueue and poll is due to kqueue and poll not working as well on Mac OS for some file types.

comment:8 in reply to:  7 Changed 16 years ago by danielluke (Daniel J. Luke)

Replying to wsiegrist@…:

The use of select instead of kqueue and poll is due to kqueue and poll not working as well on Mac OS for some file types.

Can you be more specific and/or point to where it's been reported upstream? ;-)

comment:9 Changed 16 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: assignedclosed

closing because of lack of response, feel free to re-open if you have more information.

Note: See TracTickets for help on using tickets.