#16491 closed defect (fixed)
base/src/port/port.tcl should quote homepage when opening it
| Reported by: | blb@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | MacPorts 1.7.0 |
| Component: | base | Version: | 1.7.0 |
| Keywords: | port command homepage gohome | Cc: | raimue (Rainer Müller) |
| Port: |
Description
In the code for handling the gohome command, the $homepage variable is not quoted when passed to the shell, which causes issues when a character handled by the shell is present in the homepage. To see this, try port gohome xdvipdfmx and note that the page loaded has everything from the & to the end stripped. To see a more catastrophic error, try port gohome libksba (at least until that port's homepage is corrected).
Attachments (1)
Change History (6)
comment:1 Changed 16 years ago by raimue (Rainer Müller)
| Cc: | raimue@… added |
|---|
Changed 16 years ago by blb@…
| Attachment: | base_src_port_port.tcl.diff added |
|---|
diff to base/src/port/port.tcl (on trunk)
comment:2 Changed 16 years ago by blb@…
Hmm, yeah, not sure why I went with double, even with singles not having to be escaped. Patch updated.
comment:3 Changed 16 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed your patch in r40414.
comment:4 Changed 16 years ago by tobypeterson
| Milestone: | MacPorts base bugs → MacPorts Future |
|---|
Milestone MacPorts base bugs deleted
comment:5 Changed 15 years ago by jmroot (Joshua Root)
| Milestone: | MacPorts Future → MacPorts 1.7.0 |
|---|
Note: See
TracTickets for help on using
tickets.
Shouldn't that be single quotes? With double quotes, there is still replacement for $HOME or other environment variables happening. Unlikely that it appears in an homepage URL, but let's fix it completely.