#16569 closed submission (fixed)
Atari800
Reported by: | martin.osx@… | Owned by: | krischik@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.6.0 |
Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
Port: | atari800 |
Description
atari800 is an emulator of the classic Atari 800 8bit computer.
Attachments (2)
Change History (8)
Changed 16 years ago by martin.osx@…
Attachment: | atari800-3.tar.bz2 added |
---|
comment:1 follow-up: 2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|---|
Port: | atari800 added; emulators/atari800 removed |
Thanks for the submission. I see some problems in the port as submitted:
- Atari320XE.command assumes MacPorts is installed in /opt/local; it could be installed elsewhere so you must call the file Atari320XE.command.in and use @PREFIX@ in it, then copy it to Atari320XE.command within the destroot and use reinplace within the Portfile to replace @PREFIX@ with the variable ${prefix}. See the wine port for an example of how to do this.
- Atari320XE.command assumes the user has installed the port zsh but the Portfile does not declare a runtime dependency on that port. You should either change to using Apple's zsh in /bin/zsh, or if you require the newer zsh MacPorts offers, then add a runtime dependency on the zsh port. Or you might want to rewrite the script in Mac OS X's default shell, sh, to make it easier for others to deal with this script in the future.
- The post-destroot phase of the Portfile installs things with user root and group admin. MacPorts might be installed with a different user. You should not specify a user or group when installing files.
- The Portfile assumes the user wants MacPorts applications installed in /Applications/MacPorts but in the next version of MacPorts after 1.6.0 the location will be user-configurable. See the port lisaem for an example of how this should be handled.
comment:2 Changed 16 years ago by martin.osx@…
Replying to ryandesign@…:
- Atari320XE.command assumes MacPorts is installed in /opt/local; it could be installed elsewhere so you must call the file Atari320XE.command.in and use @PREFIX@ in it, then copy it to Atari320XE.command within the destroot and use reinplace within the Portfile to replace @PREFIX@ with the variable ${prefix}. See the wine port for an example of how to do this.
done.
- Atari320XE.command assumes the user has installed the port zsh but the Portfile does not declare a runtime dependency on that port. You should either change to using Apple's zsh in /bin/zsh, or if you require the newer zsh MacPorts offers, then add a runtime dependency on the zsh port. Or you might want to rewrite the script in Mac OS X's default shell, sh, to make it easier for others to deal with this script in the future.
done.
- The post-destroot phase of the Portfile installs things with user root and group admin. MacPorts might be installed with a different user. You should not specify a user or group when installing files.
done.
- The Portfile assumes the user wants MacPorts applications installed in /Applications/MacPorts but in the next version of MacPorts after 1.6.0 the location will be user-configurable. See the port lisaem for an example of how this should be handled.
done.
I hope it is all good now.
comment:3 Changed 16 years ago by krischik@…
Owner: | changed from macports-tickets@… to krischik@… |
---|---|
Status: | new → assigned |
comment:4 Changed 16 years ago by krischik@…
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:5 Changed 16 years ago by jmroot (Joshua Root)
Type: | enhancement → submission |
---|
comment:6 Changed 16 years ago by (none)
Milestone: | Port Submissions |
---|
Milestone Port Submissions deleted
Note: See
TracTickets for help on using
tickets.
Portfile and startup script