Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#16621 closed submission (fixed)

libpqxx

Reported by: darren.weber.lists@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: mww@…, jyrkiwahlstedt, jtv@…, girgen@…
Port: libpqxx

Description

To my knowledge, this a new macport for libpqxx, version 2.6.9, and it depends on postgresql83. This is the latest stable version of libpqxx, although version 3.0 may be available soon. Nevertheless, other packages that require the interface to postgres may still depend on 2.6.9 for some time.

I have sent an email to the macport-mgr to request commit rights. Until, or if, that is confirmed, I'll use a gmail account for maintenance requests.

A list of package maintainers is given here: http://pqxx.org/development/libpqxx/wiki/PackageMaintainers

This is called postgresql-libpqxx in freeBSD. This might be a better name for the port, but this name would mangle some automatic variable settings in macports. Nevertheless, it would be nice to see this port appear in port search postgresql. See http://www.freshports.org/databases/postgresql-libpqxx/

Attachments (1)

Portfile (2.4 KB) - added by darren.weber.lists@… 16 years ago.
Portfile for libpqxx 2.6.9

Download all attachments as: .zip

Change History (10)

Changed 16 years ago by darren.weber.lists@…

Attachment: Portfile added

Portfile for libpqxx 2.6.9

comment:1 Changed 16 years ago by darren.weber.lists@…

I have not tested the port, yet. On this page:

http://pqxx.org/development/libpqxx/wiki/PackageMaintainers

There is a comment at the bottom about testing. This could be incorporated into the port at some stage of the install process (post-destroot or something).

comment:2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: libpqxx added
Status: newassigned

comment:3 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thanks. I added the port in r40155 with some minor changes.

  • I added a dependency on pkgconfig, since the configure script checks for it and the pqxx-config program uses it.
  • I removed some unnecessary lines, including the comments, which seemed to just be helpers for you to write the Portfile? The comments were just telling you how to do things that the Portfile already does.
  • I indented the long description so it's easier to read in the Portfile.

As for testing. MacPorts does have a test phase which you could write into the port if you want.

comment:4 in reply to:  3 ; Changed 16 years ago by darren.weber.lists@…

Replying to ryandesign@…:

Thanks. I added the port in r40155 with some minor changes.

  • I added a dependency on pkgconfig, since the configure script checks for it and the pqxx-config program uses it.
  • I removed some unnecessary lines, including the comments, which seemed to just be helpers for you to write the Portfile? The comments were just telling you how to do things that the Portfile already does.
  • I indented the long description so it's easier to read in the Portfile.

As for testing. MacPorts does have a test phase which you could write into the port if you want.

Great!

This is my first port contribution. How should I continue to work on the port?

a) sync and then modify the Portfile within my own local repository, or b) {{{port edit libpqxx}}

Should I use tickets to update the port with modifications?

comment:5 Changed 16 years ago by darren.weber.lists@…

Hey Ryan,

I took a look at the new Portfile: https://trac.macports.org/browser/trunk/dports/databases/libpqxx/Portfile

It has lost the line with distfiles ${distname}.tar.gz; so I assume you removed that intentionally (along with the distfile name from the checksums). If so, I conclude the fetch phase will get the right file automatically with just the port $name and $version variables. That is, the fetch config variables will use $distname and search for any compatibile archive files (.tgz, etc.).

comment:6 in reply to:  5 Changed 16 years ago by raimue (Rainer Müller)

The default for distfiles is ${distname}${extract.suffix}, while the default for ${extract.suffix} is .tar.gz. So the line is not necessary as the default is just fine.

comment:7 in reply to:  4 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to darren.weber.lists@…:

the new Portfile [...] has lost the line with distfiles ${distname}.tar.gz; so I assume you removed that intentionally (along with the distfile name from the checksums)

Yes, as Rainer said the default for distfiles is ${distname}$[extract.suffix} so that wasn't necessary. Also it's not necessary to list the distfile name in the checksums statement unless you have more than one distfile.

Replying to darren.weber.lists@…:

How should I continue to work on the port?

a) sync and then modify the Portfile within my own local repository, or b) port edit libpqxx

Should I use tickets to update the port with modifications?

When you get commit access you can just commit your changes without filing tickets, but until then, you should file tickets for your modifications and attach diffs. How you generate those diffs is up to you.

The docs will say to set up a local ports tree. Presumably the reason is so that if you make changes they won't get wiped out by the next "port sync", because the ports tree is usually synced via rsync which will wipe out local changes. However, I switched my ports tree to be a Subversion working copy. To update this, port sync just calls svn update which does not throw away local changes. This also makes it easy to get your differences to submit: instead of having to remember to make a copy of the Portfile before your changes (cp -p Portfile Portfile.orig) and then run a difference between them later (diff -u Portfile.orig Portfile), all you have to do is tell Subversion to give you the difference (svn diff).

For more help, you should send a message to macports-dev; that's better than having the discussion in this ticket.

comment:8 Changed 16 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:9 Changed 16 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.