#16672 closed defect (fixed)
portfile links are bad
| Reported by: | mark@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | website | Version: | |
| Keywords: | Cc: | yanjingfeng@…, jmpalacios (Juan Manuel Palacios), blb@… | |
| Port: |
Description
from the "available ports" link which gives you http://www.macports.org/ports.php
search for a port ... mysql5 (for instance, but anything will do)
On the query results, there are one or more hits, for instance mysql5 5.0.67 with a the "mysql5" being a link to http://trac.macports.org/browser/trunk/dports/databases%2Fmysql5/Portfile
However, this link is bad, giving an error page The requested URL /browser/trunk/dports/databases/mysql5/Portfile was not found on this server.
This happens for any/all Portfile links from Query results.
The link should be (in this example) http://trac.macports.org/browser/trunk/dports/databases/mysql5/Portfile
(using FireFox 3.03 on XPsp3)
Change History (5)
comment:1 Changed 16 years ago by blb@…
| Owner: | changed from jmpp@… to ryandesign@… |
|---|
comment:4 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | jmpp@… blb@… added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
I appear not to have realized at the time that "$row['path']" contained a slash, in the form of "<category>/<port>". I added the escaping out of the habit of escaping everything. In this case, established port and category naming rules hopefully will prevent the need for having this escaping. Juan removed it in r40385.
comment:5 Changed 16 years ago by (none)
| Milestone: | Website & Documentation |
|---|
Milestone Website & Documentation deleted
ryandesign@ appears to have added a urlencode() call to the result, which is causing this %2F escape of the slash (in r 37825, line 167). Assigning to him to find out if that's right or not...