#16964 closed update (fixed)
Updated swi-prolog-devel portfile for version 5.7.2
Reported by: | pmoura (Paulo Moura) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.6.0 |
Keywords: | Cc: | ||
Port: | swi-prolog-devel |
Description
Updated swi-prolog-devel portfile for version 5.7.2
Attachments (2)
Change History (15)
Changed 16 years ago by pmoura (Paulo Moura)
Attachment: | Portfile-swi-prolog-devel.diff added |
---|
comment:1 follow-up: 2 Changed 16 years ago by blb@…
Port: | swi-prolog-devel added |
---|
comment:2 Changed 16 years ago by pmoura (Paulo Moura)
Replying to blb@…:
Some issues/questions:
- you don't need to increase epoch unless port thinks the new version is not later than the old
- this is still the development version right (description is being changed to say stable)?
Correct.
- is the person being added to comaintain (who I notice is already there for swi-prolog and swi-prolog-lite) okay with being added here?
Jan is the author of SWI-Prolog.
- can you split the update into a non-functional patch (eg, whitespace and other things which don't affect the install) and the version increase; otherwise it makes it difficult to see what functional changes have been made
As the existing portfile is too old, I'm going to attach to this ticket the full portfile for 2.7.2.
comment:4 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… removed |
---|---|
Owner: | changed from macports-tickets@… to ryandesign@… |
Status: | new → assigned |
comment:5 follow-up: 6 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
I tested your new Portfile for 5.7.3 and it builds for me, so I'll commit it, with these changes:
- I'll keep the description as is, to say it's the development version, instead of changing it to say it's the stable version which it isn't
- I'll fix the livecheck to check for development versions, not stable versions
I'll commit it in several revisions to try to separate the logical changes.
comment:6 Changed 16 years ago by pmoura (Paulo Moura)
Replying to ryandesign@…:
I tested your new Portfile for 5.7.3 and it builds for me, so I'll commit it, with these changes:
- I'll keep the description as is, to say it's the development version, instead of changing it to say it's the stable version which it isn't
- I'll fix the livecheck to check for development versions, not stable versions
Oops! The live check should be:
livecheck.check regexm livecheck.url ${homepage}dl-beta.html livecheck.regex "Gzipped tar file holding the sources for BETA version <b>(\\d+\\.\\d+\\.\\d+)"
I'm going to upload the corrected portfile.
Changed 16 years ago by pmoura (Paulo Moura)
comment:7 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I already fixed it before I saw your new portfile. Here are the changes I committed:
comment:8 Changed 16 years ago by pmoura (Paulo Moura)
Thanks for your help in improving and committing the portfile. The only problem is your change to the maintainers. You replaced:
maintainers wielemakATscience.uva.nl pmouraATlogtalk.org
by
maintainers pmouraATmac.com
Please change it to:
maintainers J.WielemakerATuva.nl pmouraATlogtalk.org
Jan Wielemaker is the developer of SWI-Prolog and co-author of the original portfile (which we uses to build the PowerPC installer). As for me, I do not use my .Mac address for my SWI-Prolog collaborations.
comment:9 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
As indicated above, I changed the maintainers line from "pmouraATmac.com" (as it has been since swi-prolog-devel was initially created in r9569) to "wielemakATscience.uva.nl pmouraATlogtalk.org" in r42974, as you requested in your new portfile.
I will be happy to change Jan's address from "wielemakATscience.uva.nl" to "J.WielemakerATuva.nl". If that's desired, I assume I should change it uniformly, in swi-prolog, swi-prolog-devel and swi-prolog-lite?
comment:10 follow-up: 11 Changed 16 years ago by pmoura (Paulo Moura)
Thanks. Sorry for the trouble. Please also change the Jan address to J.WielemakerATuva.nl (this is his current address) and propagate the changes to all the SWI-Prolog portfiles.
comment:11 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
comment:12 Changed 16 years ago by jmroot (Joshua Root)
Type: | enhancement → update |
---|
Some issues/questions:
Thanks