BUG: gtk-theme-switch-2.0.0rc2 not building

[jbenninghoff@…]

gtk-theme-switch-2.0.0rc2 is not building properly due to its use of recently deprecated gtk2 functions. Updated Portfile & patch attached fixes the problem. Thanks to bjoern.hoffmann@…- muenchen.de for reporting the problem.

error: ---> Building gtk-theme-switch with target all Error: Target com.apple.build returned: shell command "cd "/Users/hoffmann/darwinports/dports/ x11/gtk-theme-switch/work/gtk-theme-switch-2.0.0rc2" && make all" returned error 2 Command output: cc -o switch2 switch.c -O2 -Wall -DXTHREADS -I/opt/local/include/gtk-2.0 -I/opt/ local/lib/gtk-2.0/include -I/opt/local/include/atk-1.0 -I/opt/local/include/pango-1.0 -I/opt/local/ include -I/opt/local/include/freetype2 -I/usr/X11R6/include -I/opt/local/include/glib-2.0 -I/opt/ local/lib/glib-2.0/include -DGTK_DISABLE_BROKEN -DGTK_DISABLE_DEPRECATED -L/opt/local/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -ltiff -ljpeg -lpng12 -lz -lm -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -liconv switch.c: In function `preview_clicked': switch.c:129: warning: implicit declaration of function `GTK_COMBO' switch.c:129: error: invalid type argument of `->' switch.c: In function `apply_clicked': switch.c:160: error: invalid type argument of `->' switch.c: In function `dock': switch.c:342: warning: implicit declaration of function `gtk_combo_new' switch.c:342: warning: assignment makes pointer from integer without a cast switch.c:344: warning: implicit declaration of function `gtk_combo_set_popdown_strings' make: * [switch] Error 1

[jbenninghoff@…]

updated Portfile & patch-Makefile (tarball)

[rucrazy@…]

(In reply to comment #1)

Created an attachment (id=1275) [edit] updated Portfile & patch-Makefile (tarball)

Your patch didn't work for me. I updated your patch-Makefile to explicitly tell the linker (ld) which libraries to link to.

[rucrazy@…]

gtk-theme-switch-update that works

[josh64@…]

updated portfile to gtk-theme-switch 2.0.4

[olegb@…]

build log 2.0.4 breaks on 10.4.5

[josh64@…]

updated portfile with gtk1 dep and gtk-theme-switch-2.0.4

[rhwood@…]

Some comments from an email I sent Mark Duling:

While his patch is valid, it does have a problem:

1) the port depends on gtk1 to build a program "switch" is then basically thrown away--only the program switch2 is installed

This port actually builds 2 programs: 1) switch for gtk1 and 2) switch2 for gtk2.

Using a build command "make switch2" would remove the gtk1 dependency while keeping the current end product

The larger problem I have with this port is that the port seems unclear as to what it wants to do or support.

[josh64@…]

patch for portfile to remove gtk1 version

[rhwood@…]

(In reply to comment #8)

I am unsure as to what Mark means when he says: "The larger problem I have with this port is that the port seems unclear as to what it wants to do or support.".

I said that to Mark. What I meant was does this port want support gtk1 or gtk2 or both? I probably should have had a cup of coffee before sending that message...

Anyway, I have commited the patched portfile that supports only gtk2 and am closing this bug.