Opened 16 years ago
Closed 15 years ago
#17349 closed enhancement (fixed)
svn.tag should be called svn.rev
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | MacPorts 1.8.0 |
Component: | base | Version: | 1.6.0 |
Keywords: | svn.tag svn.revision deprecate | Cc: | raimue (Rainer Müller) |
Port: |
Description
The svn.tag
keyword should really be called svn.rev
because it is where you put the revision of the repository you would like to check out. I'm sure it's just called "tag" since it was probably copied from (or maybe even shares code with) the cvs checkout feature, where cvs.tag
makes sense, since it's the tag name you want to check out.
We should allow svn.rev
as a synonym of svn.tag
. Then, once we release a version of MacPorts with that change, we should mass-update all ports to use svn.rev
instead. Then we can modify port lint
to issue a warning if you use svn.tag
and suggest you use svn.rev
instead.
Change History (4)
comment:1 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | raimue@… added |
---|
comment:2 Changed 16 years ago by raimue (Rainer Müller)
Keywords: | svn.tag svn.revision deprecate added |
---|---|
Milestone: | MacPorts Future → MacPorts 1.8.0 |
comment:3 Changed 15 years ago by raimue (Rainer Müller)
comment:4 Changed 15 years ago by jmroot (Joshua Root)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Looks fixed to me.
Note: See
TracTickets for help on using
tickets.
Oh, I have not been aware of this ticket before doing r48223.
I made it a ui_warn message now. I will take a look if we can also make it count as a warning in lint by adding another option_proc there.