#17433 closed submission (fixed)
Add py25-jinja2 port
Reported by: | arthur@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.7.0 |
Keywords: | Cc: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), blb@… | |
Port: | py25-jinja2 |
Description
We already have Jinja 1 in ports but not Jinja 2. Both versions are maintained separately by the developers.
Attachments (4)
Change History (12)
comment:1 Changed 16 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Cc: | mcalhoun@… added |
---|
comment:2 Changed 16 years ago by arthur@…
I've updated the Portfile to Jinja 2.1.1 and added a livecheck.
However, there's still a problem with the directory layout. The setup.py of Jinja2 installs the docs directly into /opt/local/docs:
Warning: violation by /opt/local/docs Warning: py25-jinja2 violates the layout of the ports-filesystems! Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!
$ port contents py25-jinja2 Port py25-jinja2 contains: /opt/local/docs/api.html /opt/local/docs/changelog.html /opt/local/docs/extensions.html /opt/local/docs/faq.html /opt/local/docs/genindex.html /opt/local/docs/index.html ...
I'm currently clueless. What would be a proper solution for this problem?
comment:3 Changed 16 years ago by nerdling (Jeremy Lavergne)
Version: | 1.6.0 → 1.7.0 |
---|
The easiest way to fix this is to move the docs
directory to be what want if it was inside of ${prefix}
and updating setup.py
's documentation_path
to reflect this. Who are our Python gurus?
comment:4 Changed 16 years ago by blb@…
Cc: | blb@… added |
---|---|
Port: | py25-jinja2 added |
distutils uses the same path as that listed in data_files (in setup.py); since that's just using 'docs' it ends up in ${prefix}/docs. Attached is a setup.py patch and updated Portfile which should fix this (into ${prefix}/share/doc/${name} like most ports).
comment:5 Changed 16 years ago by arthur@…
Thanks blb, the patch works great. I attached a Portfile for python2.4, which uses the same patch.
comment:6 Changed 16 years ago by nerdling (Jeremy Lavergne)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:7 Changed 16 years ago by jmroot (Joshua Root)
Type: | enhancement → submission |
---|
comment:8 Changed 16 years ago by (none)
Milestone: | Port Submissions |
---|
Milestone Port Submissions deleted
Cc Me!