Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#17971 closed defect (fixed)

mg @20081211 - fails to build on Panther

Reported by: face@… Owned by: lfk@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc: jmroot (Joshua Root)
Port: mg

Description

admin@x:admin:200 $ sudo port install mg
--->  Building mg
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_editors_mg/work/mg-20081211" && make all " returned error 2
Command output: gcc -O2 -pipe -g -Wall -Werror -Wno-strict-aliasing -c autoexec.c
In file included from def.h:13,
                from autoexec.c:5:
sysdef.h:49: error: field `fi_mtime' has incomplete type
make: *** [autoexec.o] Error 1

Error: Status 1 encountered during processing.

for Panther the addition of "#include <time.h>" in sysdef.h solves the problem.

Attachments (2)

patch-timespec.diff (295 bytes) - added by lfk@… 16 years ago.
Add to port tree as .../editors/mg/files/patch-timespec.diff
patch-mg-Portfile.diff (628 bytes) - added by lfk@… 16 years ago.
Patch for .../editors/mg/Portfile

Download all attachments as: .zip

Change History (8)

comment:1 Changed 16 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to lfk@…

Assigning to maintainer.

comment:2 Changed 16 years ago by lfk@…

Thanks for the report, I don't have any machines still running Panther these days. I'll make sure that adding <time.h> doesn't introduce other build issues in more recent releases.

comment:3 Changed 16 years ago by jmroot (Joshua Root)

Cc: jmr@… added

There's no need to worry about that if you do something like:

platform darwin 7 {
    patchfiles-append my_timespec_patch.diff
}

Changed 16 years ago by lfk@…

Attachment: patch-timespec.diff added

Add to port tree as .../editors/mg/files/patch-timespec.diff

Changed 16 years ago by lfk@…

Attachment: patch-mg-Portfile.diff added

Patch for .../editors/mg/Portfile

comment:4 Changed 16 years ago by lfk@…

There is no harm in including time.h directly and though I like the idea of adding a platform directive to the portfile, I really don't have a way to test it. I've attached a Portfile update and an additional file containing the patch for the timespec issue.

comment:5 Changed 16 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

Committed in r45848.

comment:6 Changed 16 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.