mp3fs: cannot install if prefix is not /opt/local and other issues

[ryandesign (Ryan Carsten Schmidt)]

There were some issues with the mp3fs port as it was submitted in #18381, first mentioned on macports-dev ​by Rainer and ​by myself:

1. The lines "distname mp3fs-${version}" and "livecheck.distname mp3fs" should be removed because those are the default values.
2. pkgconfig should be marked as a build dependency, not a library dependency.
3. Patchfiles should not reside on your personal web space; they should instead be copied to the port's files directory.
4. The string "/opt/local" should usually not occur in a portfile, because MacPorts might be installed in a different prefix. Use the variable "${prefix}" instead.

1, 2, and 3 were fixed by Jeremy in r46512. 4 was partially fixed in that revision but one occurrence of /opt/local remained, so the port still doesn't work if the prefix is not /opt/local.

Some additional points that occur to me now:

5. Your configure arguments should not be appended to "configure.post_args" but instead should be written to "configure.args" and there is no need to enclose them in quotes.
6. There is no need to use "master_sites sourceforge:mp3fs"; if the SourceForge project name is the same as the port name you can just say "master_sites sourceforge"
7. You should not put ${distfiles} into the checksums. It is unnecessary if ${distfiles} contains only a single file, as it does in this case, and it is a syntax error if it contains multiple files.

I'll attach a patch to fix these remaining issues. If you agree, I'll be happy to commit it.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

5. Your configure arguments should not be appended to "configure.post_args" but instead should be written to "configure.args" and there is no need to enclose them in quotes.

Actually, make that: these are environment variables, not arguments to the configure script, so they should go in configure.env, not configure.args. I'll update the patch.

[(none)]

Milestone Port Bugs deleted

[jmroot (Joshua Root)]

I'm pretty sure maintainer timeout has occurred and you can just commit this... ;-)

[drkp (Dan Ports)]

All either fixed or mooted in r75023