#18927 closed defect (fixed)
neon: universal issues
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | danielluke (Daniel J. Luke) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.0 |
| Keywords: | Cc: | jmroot (Joshua Root) | |
| Port: | neon |
Description
neon's pkg-config file and its neon-config script include universal flags, if neon is built universal. This causes problems for ports that depend on neon that don't want to build universal. For example, I built neon as a 4-way universal, but was unable to build apr 4-way universal because of #17090. So I built apr, apr-util and serf non-universal instead. But now subversion's build is failing because it's trying to build universal because it's picking up the universal flags from neon.
The universal flags should not be in neon's installed files.
This is the same problem that affected curl; see #14077 (for curl.pc) and #15116 (for curl-config).
I'll attach a patch to fix this.
Attachments (3)
Change History (8)
Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)
comment:1 Changed 16 years ago by jmroot (Joshua Root)
| Cc: | jmr@… added |
|---|---|
| Summary: | neon: neon.pc and neon-config include universal flags → neon: universal issues |
Changed 16 years ago by jmroot (Joshua Root)
| Attachment: | neon-config.diff added |
|---|
comment:2 Changed 16 years ago by danielluke (Daniel J. Luke)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
It would be really nice if instead of having to use variant_isset, we could have changes like this live in a unversal variant that called up to the default one (or if pre/post phases existed for +universal).
In any event, thanks for the patches, these have been committed in r48572.
comment:3 Changed 16 years ago by jmroot (Joshua Root)
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Some trailing whitespace got in there and is breaking the reinplace. Attaching a fix.
Changed 16 years ago by jmroot (Joshua Root)
| Attachment: | neon-trailingws.diff added |
|---|
comment:4 Changed 16 years ago by danielluke (Daniel J. Luke)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Additionally, the generated config.h is incorrect when both 32- and 64-bit universal_archs are used. Attached patch fixes this. Changing SIZEOF_XML_SIZE like this feels wrong, since it comes from expat, but I don't see a better way.