ffmpeg: reinplace didn't change anything in rgb2rgb.c

[ryandesign (Ryan Carsten Schmidt)]

Installing ffmpeg on Mac OS X 10.5.6 Intel with Xcode 3.1.2 and MacPorts 1.7.1 and the patch from #15514 I get:

--->  Fetching ffmpeg
--->  Attempting to fetch ffmpeg-0.5.tar.bz2 from http://seven.local/distfiles/ffmpeg
--->  Attempting to fetch ffmpeg-0.5.tar.bz2 from http://distfiles.macports.org/ffmpeg
--->  Verifying checksum(s) for ffmpeg
--->  Extracting ffmpeg
--->  Applying patches to ffmpeg
Warning: reinplace s|defined(ARCH_X86) && defined(CONFIG_GPL)|defined(ARCH_X86) \&\& defined(CONFIG_GPL) \&\& \!defined(__APPLE__)|g didn't change anything in /mp/var/macports/build/_Users_rschmidt_macports_dports_multimedia_ffmpeg/work/ffmpeg-0.5/libswscale/rgb2rgb.c
--->  Configuring ffmpeg
--->  Building ffmpeg
--->  Staging ffmpeg into destroot
[snip]

The install seems to succeed. Maybe the reinplace needs to be changed, or maybe it's no longer needed.

[dbevans (David B. Evans)]

Ryan, I've removed the reinplace from ffmpeg/ffmpeg-devel in r49616, which, indeed, did nothing in the current versions.

I wonder if you could test this on your Intel box with +mmx enabled and report as to whether or not it builds correctly. If so will make this the default as it should provide a significant speed up for Intel boxes. I suspect the disabling of mmx is hanging around from much earlier code and is outdated. But it doesn't build properly then it needs to be addressed upstream with the developers.

Thanks for pointing this out.

[ryandesign (Ryan Carsten Schmidt)]

It builds without error with the +mmx variant. I don't use ffmpeg so I'm not sure how to test that it's still fully functional with that variant.

[dbevans (David B. Evans)]

Well, it supports reading and writing so many audio and video encodings and file formats that a full test is pretty onerous but if you have some multimedia files around you can do some basic stuff like

ffmpeg -i <input file name>

will give a report on input file name (streams, encoders used, encoding parameters, etc)

ffmpeg -i <input file name> <output file name>

will convert the input file to the output format as indicated by the output file's extension

e.g. ffmpeg -i my_video.mov my_video.mp4

will convert from quicktime movie format to mpeg4 (with a report on the transcoding)

and

ffplay <multimedia file> should play just about anything that ffmpeg knows about (video and/or audio)

I suspect the majority of problems with compiling mmx in the past was the known bug in XCode 3.0 which we have seen a log of reports of.

Anyway thanks for the first level report. If some of the basic tests above work for you, I'll close this out and let ffmpeg auto select on the mmx optimizations for now.

[dbevans (David B. Evans)]

Topic of this ticket fixed in r49616. See #19314 for follow on concerning enabling of mmx optimizations.

[(none)]

Milestone Port Bugs deleted