#19409 closed submission (fixed)
redis - Add New Port
Reported by: | brianjlandau@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.7.1 |
Keywords: | Cc: | brianjlandau@… | |
Port: | redis |
Description
Redis is a key-value pair based database where the dataset exists in memory and is persisted between session on the file-system.
This is a portfile and necessary config files for a new port to be added.
Attachments (3)
Change History (17)
Changed 16 years ago by brianjlandau@…
Attachment: | redis-daemon.conf added |
---|
Changed 16 years ago by brianjlandau@…
Attachment: | redis.conf added |
---|
should go in the port's files directory
comment:2 Changed 16 years ago by blb@…
A few notes:
- get rid of epoch, that is only needed when the version is changed but doesn't appear (to port) to be newer
- use
use_configure no
instead ofconfigure {}
- for the .conf files, install them as *.conf.dist (or *.conf.sample), then in post-activate copy that to just *.conf if that file isn't already present; this way the port doesn't own *.conf (and hence removes it on upgrade), only *.conf.dist; see for example stegdetect
- is the only way to shutdown to use netcat?
comment:3 Changed 16 years ago by brianjlandau@…
I'll make the second and third changes for sure.
As for the first change, since this download is based on a git commit I thought an epoch would be a good idea as it would identify changes even if it's the same "version".
When the project is stable (the developer I believe is aiming for a 1.0 release late this summer), I think moving to downloading the "official" tarball would make sense. Until then since development is so active I thought using the git commit based tarballs would be best.
As for netcat: To properly shutdown the server you need to send the text "SHUTDOWN" via TCP to the server. As far as I know the best way to do this is with netcat. If you have a better suggestion I welcome it.
comment:4 Changed 16 years ago by blb@…
The thing about epoch is that, once set, you can never set it to something smaller or remove it. Can you use something like 0.091-20090422 as the version instead, that's how some other ports do it.
comment:5 Changed 16 years ago by brianjlandau@…
Yeah that sounds good I'll put the date in the version instead.
I'll submit a new file later today.
comment:6 Changed 16 years ago by brianjlandau@…
I think that Portfile I uploaded earlier should handle all the issues. Let me know if you need anything else.
comment:7 Changed 16 years ago by blb@…
One final issue, downloading doesn't work. Should it be using google in master_sites, since I don't see any downloads at the github downloads page?
comment:9 Changed 16 years ago by brianjlandau@…
Ok I think the current port file attached is good to go. I just decided to use the current version from Google code to reduce the complexity.
comment:10 Changed 16 years ago by blb@…
Resolution: | → fixed |
---|---|
Status: | new → closed |
Added in r50229, thanks for the work.
comment:11 Changed 16 years ago by jmroot (Joshua Root)
Type: | enhancement → submission |
---|
comment:12 Changed 16 years ago by (none)
Milestone: | Port Submissions |
---|
Milestone Port Submissions deleted
should go in the port's files directory