lilypond: creates unregistered symlinks in ${prefix}/lib and /usr/lib

[ryandesign (Ryan Carsten Schmidt)]

I have a couple problems with the "create symlinks" part of the pre-build phase of the lilypond portfile. It reads:

            # create symlinks
    if { [file exists "/usr/lib/libguile-srfi-srfi-1-v-3.so"] == 0 } \
        { ln -s ${prefix}/lib/libguile-srfi-srfi-1-v-3.so /usr/lib/libguile-srfi-srfi-1-v-3.so }
    if { [file exists "${prefix}/lib/libguile-srfi-srfi-1-v-3.so"] == 0 } \
        { ln -s ${prefix}/lib/libguile-srfi-srfi-1-v-3.dylib ${prefix}/lib/libguile-srfi-srfi-1-v-3.so }

This code seems to create a symlink in /usr/lib and ${prefix}/lib. A port should not do the former because it is outside of ${prefix}. And in both cases, the symlink is being created outside ${destroot} and is thus not registered to the port. Why are these symlinks needed by this software, and is there any other way the same goal could be accomplished without writing files outside the destroot?

[nerdling (Jeremy Lavergne)]

These were fixed in the latest update: r51779 for #19811.