Opened 15 years ago
Closed 15 years ago
#20241 closed defect (fixed)
qt4-mac: qmake no longer includes /opt/local/lib as a library path
| Reported by: | dh@… | Owned by: | erickt@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.1 |
| Keywords: | Cc: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), clubjuggler@…, skymoo (Adam Mercer), celemourn@…, boeyms@…, mf2k (Frank Schima), patrick.sizun@…, nerdling (Jeremy Lavergne) | |
| Port: | qt4-mac |
Description (last modified by mf2k (Frank Schima))
Revision r53399 makes a change to how configure is invoked, altering CPATH and LIBRARY_PATH over passing -L to configure.
Downstream, this causes py26-pyqt4 to fail to build as it is unable to find -lpng, as there is no -L${prefix} in the Makefiles generated by qmake.
Perhaps this is the case in any project depending on qt4-mac. Unfortunately qmake is a bit of a mystery to me.
If the Portfile is patched to include -L in the configure args then py26-pyqt4 builds correctly.
I suspect that all of the -isystem and -L flags need to be returned as opposed to manipulating CPATH and LIBRARY_PATH.
Patch attached only adds the -L flag to allow py26-qt4 to build. Probably the other variants need to add -L's over using LIBRARY_PATH as well??
Attachments (1)
Change History (15)
Changed 15 years ago by dh@…
| Attachment: | Portfile.patch added |
|---|
comment:1 Changed 15 years ago by skymoo (Adam Mercer)
| Cc: | ram@… added |
|---|
comment:4 Changed 15 years ago by boeyms@…
| Cc: | boeyms@… added |
|---|
Replying to dh@…:
I suspect that all of the -isystem and -L flags need to be returned as opposed to manipulating CPATH and LIBRARY_PATH.
The qmake documentation lists environment variables that can be set to make it add directories to be searched for headers and libraries. It also says that such changes can be made in qmake.conf, of which one is installed qt4-mac and qt4-x11 by each platform-compiler combination that it knows about, so it would probably be better if the maintainers of those ports made sure that the required changes are made there instead.
comment:5 Changed 15 years ago by dh@…
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Closing as invalid - py26-pyqt4 has been patched to allow it to compile.
comment:6 follow-up: 7 Changed 15 years ago by celemourn@…
This has not been resolved. py26-pyqt4 is not the only port that suffers from this problem. Basically anything that uses qt4 is going to have trouble installing. Manually applying the patch above to the portfile does resolve it, but this needs to be worked into the port itself.
comment:7 Changed 15 years ago by julio.lopez@…
Ditto. This issue has not been resolved. For example, qscintilla depends on qt4-mac and is also affected by this issue.
comment:8 Changed 15 years ago by mf2k (Frank Schima)
| Description: | modified (diff) |
|---|---|
| Resolution: | invalid |
| Status: | closed → reopened |
comment:12 Changed 15 years ago by mf2k (Frank Schima)
I committed the patch in r54186. Thanks dh! py25-pyqt4 and qscintilla now compile for me. I'd like some feedback (good or bad) on this patch before I close the ticket.
comment:14 Changed 15 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Cc Me!