Opened 15 years ago
Closed 15 years ago
#20272 closed update (fixed)
Update multimedia/VLC to version 1.0.0
| Reported by: | max@… | Owned by: | nerdling (Jeremy Lavergne) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.1 |
| Keywords: | Cc: | ||
| Port: | VLC |
Description (last modified by nerdling (Jeremy Lavergne))
This patch is an update for VLC to version 1.0.0.
The biggest change is, that of 1.0.0 llvm is required to correctly build VLC (see for example this thread or the forum).
This has the effect that VLC is only available for 10.5.
Additionally a new patch is required to prevent automatic linking to X11 when XCB files are present.
Also +bonjour has been removed from +huge as the avahi port currently doesn't build.
The version update also depends on ticket #20206.
The patch is quite large since it also fixes mixing of tabs and spaces.
Attachments (3)
Change History (7)
Changed 15 years ago by max@…
| Attachment: | Portfile-1.0.0.diff added |
|---|
Changed 15 years ago by max@…
| Attachment: | configure.ac-xcb.diff added |
|---|
Changed 15 years ago by max@…
| Attachment: | Makefile.am.diff added |
|---|
comment:1 Changed 15 years ago by nerdling (Jeremy Lavergne)
| Description: | modified (diff) |
|---|---|
| Keywords: | VLC removed |
| Owner: | changed from macports-tickets@… to snc@… |
| Status: | new → assigned |
comment:2 Changed 15 years ago by nerdling (Jeremy Lavergne)
Please, please make sure you put whitespace changes in their own diff! I had two massive chunks fail in this portfile because the base version you had used didn't match what was in MacPorts and the whitespace changes added to the mess. The time between me taking ownership and now is how long it took to fix just the Portfile patch.
comment:3 Changed 15 years ago by nerdling (Jeremy Lavergne)
Warning: Patchfile Makefile.am.diff does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile configure.ac-xcb.diff does not follow the source patch naming policy "patch-*.diff"
I'm going to go ahead and rename the patchfiles. Should be the last thing—
comment:4 Changed 15 years ago by nerdling (Jeremy Lavergne)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed in r53864.
Makefile.am.diff needs to be updated too, else it fails to apply