Opened 15 years ago

Closed 15 years ago

#20381 closed update (fixed)

nzbget 0.6.0 - updated portfile for latest release

Reported by: fracai Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: nzbget, nzb, usenet Cc: ryandesign (Ryan Carsten Schmidt)
Port: nzbget

Description

Version bump for nzbget to the latest release.

Also, the patches included with the existing Portfile (0.2.3) are no longer needed.

Attachments (7)

Portfile (1.2 KB) - added by fracai 15 years ago.
Portfile for nzbget (0.6.0)
Portfile-nzbget.diff (2.4 KB) - added by fracai 15 years ago.
Portfile diff for nzbget (0.6.0)
Portfile-nzbget2.diff (2.1 KB) - added by fracai 15 years ago.
diff ignoring whitespace
nzbget-leopard.txt (24.0 KB) - added by ryandesign (Ryan Carsten Schmidt) 15 years ago.
build log from leopard
nzbget-tiger.txt (22.8 KB) - added by ryandesign (Ryan Carsten Schmidt) 15 years ago.
build log from tiger
Portfile.2 (1.5 KB) - added by fracai 15 years ago.
Portfile - updated with OpenSSL dependency
Portfile-nzbget-corrected.diff (2.4 KB) - added by fracai 15 years ago.
Portfile diff - updated with OpenSSL dependency

Download all attachments as: .zip

Change History (16)

Changed 15 years ago by fracai

Attachment: Portfile added

Portfile for nzbget (0.6.0)

comment:1 Changed 15 years ago by tobypeterson

ugh. diff please

comment:2 in reply to:  1 Changed 15 years ago by fracai

Here you go. Also, note that nzbget now requires the new libpar2 port that I posted (#20380).

Changed 15 years ago by fracai

Attachment: Portfile-nzbget.diff added

Portfile diff for nzbget (0.6.0)

comment:3 Changed 15 years ago by jmroot (Joshua Root)

If you can't avoid making whitespace changes in the first place, at least tell diff to ignore them.

Changed 15 years ago by fracai

Attachment: Portfile-nzbget2.diff added

diff ignoring whitespace

comment:4 Changed 15 years ago by fracai

I followed the instructions in the guide which don't specify ignoring whitespace. And the only whitespace instructions I see (after searching further just now) are on the "New Committers" page. Sorry for missing that.

I figured that since almost everything in this Portfile changed with this update it'd be easier to simply upload the full file.

In the future I'll limit any whitespace changes.

comment:5 Changed 15 years ago by tobypeterson

Whitespace changes are fine, it's just hard to evaluate a change that contains both code changes and whitespace changes. And I was feeling lazy when I made my initial comment. ;)

comment:6 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

0.6.0 doesn't build for me on either Tiger or Leopard, with different errors. On Leopard it says:

Undefined symbols:
  "_gcry_control", referenced from:
      tls_lib_init(char**) in TLS.o

That symbol is from gcrypt. On Tiger it says:

Thread.cpp: In member function 'void Semaphore::CreateSemObj(int)':
Thread.cpp:138: error: ISO C++ forbids comparison between pointer and integer

I don't know what the deal is there.

Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: nzbget-leopard.txt added

build log from leopard

Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: nzbget-tiger.txt added

build log from tiger

comment:7 Changed 15 years ago by fracai

At least for Leopard, it looks like your configure picked gnutls, while mine picked ssl. I'm checking now to see if that makes a difference and I need to specify which is used.

comment:8 in reply to:  7 Changed 15 years ago by fracai

Replying to arno+macports@…:

At least for Leopard, it looks like your configure picked gnutls, while mine picked ssl. I'm checking now to see if that makes a difference and I need to specify which is used.

Yep, I get the same error when forcing gnutls. I've added openssl as a dependency, forced the use of that library, and re-added the Portfile and diff. (I'm including both because of the magnitude of changes).

Changed 15 years ago by fracai

Attachment: Portfile.2 added

Portfile - updated with OpenSSL dependency

Changed 15 years ago by fracai

Portfile diff - updated with OpenSSL dependency

comment:9 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Thanks, it builds on Leopard now. I committed the new portfile in r54796 and filed #20517 for the build failure on Tiger.

Note: See TracTickets for help on using tickets.