Opened 15 years ago

Closed 15 years ago

#20486 closed update (fixed)

update emacs to 23.1, remove carbon/cocoa bits

Reported by: brett@… Owned by: darren.bane@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryan_ware@…, docwhat@…, tonytung@…, hong.rich@…, macports@…, mcamou@…, pff@…, jdfrens@…, chalin@…, luis.beca@…, ronhuang@…, miqqis@…, bob.spamnot@…, jsg8pitt@…, nerdling (Jeremy Lavergne), drkp (Dan Ports)
Port: emacs

Description

The carbon port is dead, long live --with-ns

Attachments (3)

emacs-cocoa.diff (2.3 KB) - added by tobypeterson 15 years ago.
Portfile (2.4 KB) - added by bob.spamnot@… 15 years ago.
emacs.diff (2.5 KB) - added by nerdling (Jeremy Lavergne) 15 years ago.
diff with bob's portfile

Download all attachments as: .zip

Change History (21)

Changed 15 years ago by tobypeterson

Attachment: emacs-cocoa.diff added

comment:1 Changed 15 years ago by tobypeterson

Added a patch that makes it sort of compile, albeit with tons of warnings. Their so-called Cocoa port is about as awful as I would've expected. :)

comment:2 in reply to:  1 Changed 15 years ago by bob.spamnot@…

I would recommend keeping the X11 variants (X11 and gtk, especially) separate from the cocoa version, as in is now. The cocoa version would be in emacs-app. This is due to the fact that they are quite different in where they get installed. Furthermore, the X11 variants work very well and the cocoa version is still work in progress and has problems.

The carbon version is gone and should be removed from the 23.1 port.

comment:3 Changed 15 years ago by blb@…

Cc: ryan_ware@… added

Cc reporter of dup #20745.

comment:4 Changed 15 years ago by bob.spamnot@…

Why the delay on this upgrade? It should be straightforward. I've enclosed a Portfile which I think should work. It eliminates all mention of carbon, has no emacs-app as that is in a separate port (which I see is already upgraded to 23.1) and updates the md5. I don't think any patchfiles are needed and the --without-x is changed to --with-x-toolkit=no.

Give it a try (on Leopard, as I've heard emacs won't compile on SL but that's a separate issue).

Changed 15 years ago by bob.spamnot@…

Attachment: Portfile added

comment:5 Changed 15 years ago by tobypeterson

I think the approach of removing carbon & cocoa is good - we have emacs-app for that. I'm guessing the maintainer is AWOL - Darren?

comment:6 Changed 15 years ago by tobypeterson

Summary: update emacs to 23.1 and change carbon port to cocoaupdate emacs to 23.1, remove carbon/cocoa bits

comment:7 Changed 15 years ago by tobypeterson

Cc: docwhat@… tonytung@… hong.rich@… macports@… mcamou@… pff@… jdfrens@… chalin@… added
Version: 1.7.1

comment:8 Changed 15 years ago by luis.beca@…

Cc: luis.beca@… added

Cc Me!

comment:9 Changed 15 years ago by nerdling (Jeremy Lavergne)

If I'm reading bob's portfile correctly, we're removing the --without-carbon arg. Is that right?

Changed 15 years ago by nerdling (Jeremy Lavergne)

Attachment: emacs.diff added

diff with bob's portfile

comment:10 Changed 15 years ago by ronhuang@…

Cc: ronhuang@… added

Cc Me!

comment:11 Changed 15 years ago by miqqis@…

Cc: miqqis@… added

Cc Me!

comment:12 in reply to:  9 Changed 15 years ago by bob.spamnot@…

Replying to snc@…:

If I'm reading bob's portfile correctly, we're removing the --without-carbon arg. Is that right?

Yes, --without-carbon is not needed with the 23.1 build system since it defaults to X11 first. I suppose it would not hurt anything.

comment:13 Changed 15 years ago by bob.spamnot@…

Cc: bob.spamnot@… added

Cc Me!

comment:14 Changed 15 years ago by jsg8pitt@…

Cc: jsg8pitt@… added

Cc Me!

comment:15 Changed 15 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added

Cc Me!

comment:16 Changed 15 years ago by drkp (Dan Ports)

Cc: dports@… added

Cc Me!

comment:17 Changed 15 years ago by blair (Blair Zajac)

Fixed in r62682. See #23165 for more information.

comment:18 Changed 15 years ago by blair (Blair Zajac)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.