Opened 15 years ago

Closed 15 years ago

#20664 closed enhancement (fixed)

Enable smartcard support to rdesktop

Reported by: thomas.akesson@… Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc: cshbell@…, mf2k (Frank Schima)
Port: rdesktop

Description

I would like to suggest adding a variant to the Portfile enabling the smartcard forwarding supported by rdesktop 1.6. I tested by adding the following, which seems to work:

variant smartcard description {enables smartcard forwarding} {

configure.args-append --enable-smartcard

}

There is a requirement for PCSC-lite 1.2.9 or later noted in rdesktop release notes. The pcscd distributed with Mac OS 1.5.7 reports: PCSC Framework version 1.4.0.

I have tested this by modifying the Portfile and I can successfully forward the smartcard to a Win2003 server.

Attachments (2)

Portfile (1.3 KB) - added by cshbell@… 15 years ago.
Portfile-rdesktop.diff (977 bytes) - added by cshbell@… 15 years ago.

Download all attachments as: .zip

Change History (11)

Changed 15 years ago by cshbell@…

Attachment: Portfile added

comment:1 Changed 15 years ago by cshbell@…

Looks good. Portfile attached above. Maintainer noses@… dropped, per his request.

Please merge into trunk.

comment:2 Changed 15 years ago by cshbell@…

Cc: cshbell@… added

Cc Me!

comment:3 in reply to:  1 Changed 15 years ago by mf2k (Frank Schima)

Replying to cshbell@…:

Looks good. Portfile attached above. Maintainer noses@… dropped, per his request.

Please merge into trunk.

A couple of observations:

  • A unified diff is preferred.
  • Your portfile is revision 1 of version 1.6.0. But the current version is already at revision 2.
  • The first line of your portfile is invalid.
  • Your email address needs to be obfuscated.

Changed 15 years ago by cshbell@…

Attachment: Portfile-rdesktop.diff added

comment:4 Changed 15 years ago by cshbell@…

Diff attached.

comment:5 Changed 15 years ago by mf2k (Frank Schima)

Cc: macsforever2000@… added

Cc Me!

comment:6 Changed 15 years ago by thomas.akesson@…

What is the process for getting the diff merged into trunk?

comment:7 Changed 15 years ago by blb@…

That diff definitely doesn't seem to be against the Portfile in the repository, everything is colon-delimited in the patched Portfile but definitely not in the real one.

comment:8 Changed 15 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to macsforever2000@…
Status: newassigned

comment:9 Changed 15 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: assignedclosed

Next time, please supply a proper patch based on the latest version of the portfile from the repository. Updated in r57543.

Note: See TracTickets for help on using tickets.