Opened 15 years ago

Closed 15 years ago

#20900 closed defect (fixed)

googlecode livecheck not working with http://project-name.googlecode.com style urls

Reported by: 0xced (Cédric Luthi) Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.8.2
Component: base Version: 1.8.0
Keywords: Cc: nerdling (Jeremy Lavergne), ryandesign (Ryan Carsten Schmidt)
Port:

Description

As I'm unable to reopen #20723, I'm creating this new ticket.

googlecode livecheck code assumes the homepage of a googlecode project is in the format http://code.google.com/p/project-name/

This is not always true (e.g. the mp4v2 port).

The attached patch also accepts the http://project-name.googlecode.com format.

Attachments (1)

googlecode-livecheck-name.patch (753 bytes) - added by 0xced (Cédric Luthi) 15 years ago.

Download all attachments as: .zip

Change History (10)

Changed 15 years ago by 0xced (Cédric Luthi)

comment:1 Changed 15 years ago by nerdling (Jeremy Lavergne)

Is the differing homepage simply a matter they both work and we only check for one?

comment:2 Changed 15 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added

comment:3 in reply to:  1 Changed 15 years ago by 0xced (Cédric Luthi)

Replying to snc@…:

Is the differing homepage simply a matter they both work and we only check for one?

Yes, exactly.

comment:4 Changed 15 years ago by nerdling (Jeremy Lavergne)

Check out the code that's in trunk. Does it do what you're after?

The livecheck.name section is moved up from the section you were patching, it seems.

comment:5 Changed 15 years ago by 0xced (Cédric Luthi)

I just tried to build the trunk (r57011), but it still does not work:

$ port -v livecheck mp4v2
Error: cannot check if mp4v2 was updated (regex didn't match)

Where (what changeset) exactly did the livecheck.name section move up happened?

comment:6 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

comment:7 Changed 15 years ago by wsiegrist@…

Milestone: MacPorts 1.8.1MacPorts 1.8.2

comment:8 Changed 15 years ago by jmroot (Joshua Root)

1.8.1 milestone is closing, moving open tickets out

comment:9 Changed 15 years ago by nerdling (Jeremy Lavergne)

Resolution: fixed
Status: newclosed

Committed in r60451.

Note: See TracTickets for help on using tickets.