hping2 does not build with +universal

[macports@…]

DEBUG: Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_hping2/work/hping2-rc3" && /usr/bin/make -j2 all'
gcc -c -O2 -Wall  -g  arsglue.c
gcc -c -O2 -Wall  -g  scan.c
scan.c: In function 'receiver':
scan.c:455: warning: pointer targets in assignment differ in signedness
gcc -c -O2 -Wall  -g  hstring.c
scan.c:456: warning: call to __builtin___memcpy_chk will always overflow destination buffer
gcc -c -O2 -Wall  -g  ars.c
ars.c: In function 'ars_multi_cksum':
ars.c:433: warning: comparison with string literal results in unspecified behavior
gcc -c -O2 -Wall  -g  apd.c
gcc -c -O2 -Wall  -g  split.c
/usr/bin/ar rc libars.a ars.o apd.o split.o
/usr/bin/ranlib libars.a
gcc -o hping2 -O2 -Wall  -g main.o getifname.o getlhs.o linux_sockpacket.o parseoptions.o datafiller.o datahandler.o gethostname.o binding.o getusec.o opensockraw.o logicmp.o waitpacket.o resolve.o sendip.o sendicmp.o sendudp.o sendtcp.o cksum.o statistics.o usage.o version.o antigetopt.o sockopt.o listen.o sendhcmp.o memstr.o rtt.o relid.o sendip_handler.o libpcap_stuff.o memlockall.o memunlockall.o memlock.o memunlock.o ip_opt_build.o display_ipopt.o sendrawip.o signal.o send.o strlcpy.o arsglue.o random.o scan.o hstring.o libars.a -lpcap 

./hping2 -v
hping version 2.0.0-rc3 (Mon May  3 10:56:19 CEST 2004)
libpcap based binary
use `make strip' to strip hping2 binary
use `make install' to install hping2
DEBUG: Executing proc-post-org.macports.build-build-0
-rwxr-xr-x  1 root  admin  120016 Aug 30 17:34 ./hping2
strip hping2
-rwxr-xr-x  1 root  admin  86720 Aug 30 17:34 ./hping2
/opt/local/var/macports/sources/rsync.macports.org/release/ports/net/hping2
DEBUG: couldn't read file "Makefile": no such file or directory
    while executing
"exec /usr/bin/sed s|INSTALL_PATH=|INSTALL_PATH=/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_hpin..."
    ("eval" body line 1)
    invoked from within
"eval exec $cmdline"
Error: reinplace: couldn't read file "Makefile": no such file or directory
Error: Target org.macports.build returned: reinplace sed(1) failed
DEBUG: Backtrace: reinplace sed(1) failed
    while executing
"$post $targetname"
Warning: the following items did not execute (for hping2): org.macports.activate org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.

A solution is applying the attached patch to the Portfile.

[macports@…]

Move changes in Makefile to post-configure

[nerdling (Jeremy Lavergne)]

I just tried installing hping2 +universal and did not have an issue.

Either way, the portfile shouldn't use "system cd" just to move around. It should be used as a prefix for the reinplace paths.

[nerdling (Jeremy Lavergne)]

Committed in r56909.