#20936 closed defect (fixed)
emacs-app fails to build on Snow Leopard
| Reported by: | cssdev | Owned by: | cssdev |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.8.0 |
| Keywords: | Cc: | vipul.delwadia@…, julian@…, tonytung@…, james.mcbride+trac_ext@…, kiwi.2008@…, macports@…, vdesjardins@…, bgraw3@…, macports@…, kalyaka@…, distant.journey.dreaming.journey@…, colding@…, agl2015, lorne@…, eddieh (Eddie Hillenbrand), chalin@…, easye, mfisher@…, bloosqr@…, jochen@…, ggeremy@…, jochen3941@…, hawkins22@…, jpenney (Jason Penney), davida@…, hgbrauen@…, dcreager@…, marcin.zalewski@…, league@…, squarepegsys (Mike Hostetler), lambda@…, jbarnette@…, whitley@…, andy@…, hvitved@…, wouter.beek@…, tim@…, travis.vachon@…, bonelake@…, hiroki.ora@…, mrb@…, overcyn@…, nlavine@…, nerdling (Jeremy Lavergne), royliu@…, vallon (Justin), larryv (Lawrence Velázquez), tolsen (Tim Olsen), julienb@…, livin.stephen@…, andreas.wilm@…, ldeck | |
| Port: | emacs-app emacs-app-devel |
Description (last modified by cssdev)
The emacs-app source fails to build properly on Snow Leopard.
---> Building emacs-app
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_Users_Shared_macports_dports_aqua_emacs-app/work/emacs-23.1" && /usr/bin/make -j2 all " returned error 2
Command output: nsterm.m: In function '-[EmacsView keyDown:]':
nsterm.m:4611: warning: 'wantsToDelayTextChangeNotifications' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:112)
nsterm.m: In function '-[EmacsView characterIndexForPoint:]':
nsterm.m:4820: warning: conflicting types for '-(unsigned int)characterIndexForPoint:(NSPoint)thePoint'
/System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:45: warning: previous declaration of '-(NSUInteger)characterIndexForPoint:(NSPoint)thePoint'
nsterm.m: In function '-[EmacsView initFrameFromEmacs:]':
nsterm.m:5219: warning: class 'EmacsView' does not implement the 'NSWindowDelegate' protocol
nsterm.m: In function '-[EmacsView draggingEntered:]':
nsterm.m:5497: warning: conflicting types for '-(unsigned int)draggingEntered:(id <NSDraggingInfo>)sender'
/System/Library/Frameworks/AppKit.framework/Headers/NSDragging.h:56: warning: previous declaration of '-(NSDragOperation)draggingEntered:(id <NSDraggingInfo>)sender'
nsterm.m: In function '+[EmacsScroller scrollerWidth]':
nsterm.m:5782: warning: conflicting types for '+(float)scrollerWidth'
/System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:76: warning: previous declaration of '+(CGFloat)scrollerWidth'
nsterm.m: In function '-[EmacsScroller setPosition:portion:whole:]':
nsterm.m:5912: warning: 'setFloatValue:knobProportion:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:107)
nsterm.m:5919: warning: 'setFloatValue:knobProportion:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:107)
nsterm.m: In function '-[EmacsScroller mouseDown:]':
nsterm.m:6024: warning: format '%d' expects type 'int', but argument 3 has type 'NSScrollerPart'
make[1]: *** [nsterm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from nsterm.h:20,
from nsfns.m:37:
dispextern.h:1250: error: array type has incomplete element type
nsfns.m: In function 'Fxw_color_values':
nsfns.m:2252: warning: passing argument 1 of 'getRed:green:blue:alpha:' from incompatible pointer type
nsfns.m:2252: warning: passing argument 2 of 'getRed:green:blue:alpha:' from incompatible pointer type
nsfns.m:2252: warning: passing argument 3 of 'getRed:green:blue:alpha:' from incompatible pointer type
nsfns.m:2252: warning: passing argument 4 of 'getRed:green:blue:alpha:' from incompatible pointer type
make[1]: *** [nsfns.o] Error 1
make: *** [src] Error 2
Error: Status 1 encountered during processing.
I tried to fix that using the latest nsfns.m, but that only led to additional errors. The latest cvs checkout from savannah fails to build for others as well, so it looks like this port needs to wait for more significant upstream fixes.
Attachments (5)
Change History (84)
comment:1 Changed 15 years ago by vipul.delwadia@…
| Cc: | vipul.delwadia@… added |
|---|
comment:3 Changed 15 years ago by nerdling (Jeremy Lavergne)
| Port: | emacs-app-devel added |
|---|
comment:5 Changed 15 years ago by james.mcbride+trac_ext@…
| Cc: | james.mcbride+trac_ext@… added |
|---|
Cc Me!
comment:12 Changed 15 years ago by distant.journey.dreaming.journey@…
| Cc: | distant.journey.dreaming.journey@… added |
|---|
Cc Me!
comment:13 Changed 15 years ago by nerdling (Jeremy Lavergne)
| Cc: | colding@… added |
|---|
Adding reporter of duplicate #21114.
comment:14 Changed 15 years ago by nerdling (Jeremy Lavergne)
| Cc: | artemiogl@… added |
|---|
Adding reporter of duplicate #21109.
comment:15 Changed 15 years ago by cssdev
| Description: | modified (diff) |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by colding@…
| Attachment: | emacs-app.txt.bz2 added |
|---|
Output of "sudo port -d install emacs-app 2>&1 | tee ~/emacs-app.txt"
comment:19 Changed 15 years ago by easye
| Cc: | easieste added |
|---|
comment:20 Changed 15 years ago by easye
| Cc: | easieste@… added; easieste removed |
|---|
Changed 15 years ago by eddieh (Eddie Hillenbrand)
| Attachment: | emacs-app-snow-leopard.patch added |
|---|
This patch should allow emacs.app to be built on Snow Leopard. Thanks goes to Erik Charlebois who posted instructions to the emacs-devel list. After the patch is applied there are still a few warnings...
comment:22 Changed 15 years ago by cssdev
MacPorts fails to apply this patch. It probably needs some modifications to conform to the details on creating patches. After you built it, did it work?
comment:24 Changed 15 years ago by eddieh (Eddie Hillenbrand)
Oh oops. The patch was against emacs cvs not the portfile. Erik Charlebois has now put his patch up on the emacs-devel list which is more complete than my minimalist patch. Maybe someone can modify the emacs-app-devel port so that it applies the patch file. I don't really know the policy for source code patches, perhaps it would be better to wait till the patches are applied upstream.
comment:33 Changed 15 years ago by dcreager@…
I've been able to get emacs-app to work on Snow Leopard. I had to use Erik Charlebois's patch (referenced earlier), as well as a patch from Yamamoto Mitsuharu. With these two patches, emacs-app compiles and installs cleanly from a local ports archive.
I haven't been able to test whether the port still works on Leopard and earlier with this patch.
I'll attach the Portfile patch and the source patch that it uses.
Changed 15 years ago by dcreager@…
| Attachment: | emacs-app-Portfile-snow-leopard.patch added |
|---|
Patch to Portfile that allows installation on Snow Leopard
Changed 15 years ago by dcreager@…
| Attachment: | emacs-23.1-snow-leopard.patch added |
|---|
Source tree patch used by emacs-app Portfile
comment:35 Changed 15 years ago by jamshid@…
If like me you're new to macports and wondering what to do with those two .patch files, good luck, this seemed to work for me:
sudo port clean emacs-app sudo port install emacs-app cd $(port dir emacs-app) sudo patch -p0 < ~/Downloads/emacs-app-Portfile-snow-leopard.patch sudo cp emacs-23.1-snow-leopard.patch ./files/ sudo port -D . install
Now open Finder to /Applications/MacPorts/Emacs.app.
comment:42 follow-ups: 43 44 Changed 15 years ago by royliu@…
Hi all, I've converted the patches talked about above into a MacPorts-compliant format, and have successfully built emacs-app. Would the SVN maintainers of the port be able to commit it? I've attached a patch archive for the port itself, port-patch.tar.gz. In it, you will find: files-add/, a directory of patches that need to be added to the port; and files-patch/, a directory of files that need to be patched.
Changed 15 years ago by royliu@…
| Attachment: | port-patch.tar.gz added |
|---|
A patch for the port itself, after integrating all earlier patches.
comment:43 Changed 15 years ago by cssdev
Replying to royliu@…:
Would the SVN maintainers of the port be able to commit it?
I had hoped that there would be more activity upstream to integrate all required changes to make things work on snow leopard. I don't want to manage a completely separate set of sources. I'll test and commit the changes. Thanks for rolling everything together!
comment:44 Changed 15 years ago by cssdev
Replying to royliu@…:
I've attached a patch archive for the port itself, port-patch.tar.gz.
Safari doesn't like that ... it tries to download the page, not the attachment itself. I had to manually use the full URL https://trac.macports.org/attachment/ticket/20936/port-patch.tar.gz to get the patch. I'll try the patch.
comment:58 Changed 15 years ago by nlavine@…
I find that this issue still happens. To clarify, has the patch that fixed the old issue been put in the ports tree, or does it still have the old version?
comment:59 follow-up: 60 Changed 15 years ago by royliu@…
Build issues seem to be fixed in the upstream. I checked out with
cvs -z3 -d:pserver:anonymous@cvs.savannah.gnu.org:/sources/emacs co emacs
did
./configure --with-ns
and the build went fine. Could someone with commit privileges update emacs-app-devel to reflect this change (check out from a more recent revision)?
comment:60 Changed 15 years ago by cssdev
Replying to royliu@…:
Build issues seem to be fixed in the upstream.
Great! Last weekend's checkout (10/26) still exhibited problems, but I'll try with today. If it works, I'll commit to emacs-app-devel.
comment:72 follow-up: 73 Changed 15 years ago by cssdev
Use emacs-app-devel until there's an upstream release with Snow Leopard support.
comment:73 Changed 15 years ago by cssdev
Replying to css@…:
Use emacs-app-devel until there's an upstream release with Snow Leopard support.
I guess it's time to see if emacs 23.2 works ...
comment:74 follow-up: 75 Changed 15 years ago by cssdev
Seems to work for me. I committed emacs-app 23.2 in r67427. Please verify that it works for you, and this ticket might finally be closed!
comment:75 Changed 15 years ago by larryv (Lawrence Velázquez)
comment:76 follow-up: 77 Changed 15 years ago by easye
Under the new port, my emacsclient doesn't seem to be working. Setting EDITOR to '/Applications/MacPorts/Emacs.app/Contents/MacOS/bin/emacsclient', invoking M-x server-start in Emacs and then executing a program from the commandline that uses EDITOR, results in the following error message:
/Applications/MacPorts/Emacs.app/Contents/MacOS/bin/emacsclient: can't find socket; have you started the server? To start the server in Emacs, type "M-x server-start". /Applications/MacPorts/Emacs.app/Contents/MacOS/bin/emacsclient: No socket or alternate editor. Please use: --socket-name --server-file (or environment variable EMACS_SERVER_FILE) --alternate-editor (or environment variable ALTERNATE_EDITOR)
comment:77 Changed 15 years ago by easye
Replying to easieste@…:
Under the new port, my emacsclient doesn't seem to be working. Setting EDITOR to '/Applications/MacPorts/Emacs.app/Contents/MacOS/bin/emacsclient', invoking M-x server-start in Emacs and then executing a program from the commandline that uses EDITOR, results in the following error message:
My apologies:
False error report, please ignore (a copy of emacs-22 was being invoked by mistake)
comment:78 Changed 15 years ago by cssdev
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Thanks for the feedback. I'm closing this ticket, so if other issues arise with emacs-app, please file those into new tickets.
Cc Me!