Vidalia doesn't build on Snow Leopard with qt-mac +cocoa (version 64 bit)

[hsivank@…]

This is the error

/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp: In member function 'CGImage* TrayIconImpl::createIconFromFile(FSSpec)':
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:60: error: 'ReadIconFile' was not declared in this scope
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp: In member function 'void TrayIconImpl::show()':
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:151: error: 'BeginCGContextForApplicationDockTile' was not declared in this scope
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:155: error: 'SetApplicationDockTileImage' was not declared in this scope
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:156: error: 'EndCGContextForApplicationDockTile' was not declared in this scope
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp: In member function 'void TrayIconImpl::hide()':
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:168: error: 'BeginCGContextForApplicationDockTile' was not declared in this scope
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:172: error: 'RestoreApplicationDockTileImage' was not declared in this scope
/opt/local/var/macports/build/_opt_ports.git_dports_security_Vidalia/work/vidalia-0.1.15/src/vidalia/tray/trayicon_mac.cpp:173: error: 'EndCGContextForApplicationDockTile' was not declared in this scope
make[2]: *** [src/vidalia/CMakeFiles/Vidalia.dir/tray/trayicon_mac.o] Error 1

[hsivank@…]

It seems that Vidalia use Carbon API to control dock icon ...

[mf2k (Frank Schima)]

Did you get qt4-mac +cocoa to compile on Snow Leopard? Did you modify the portfile?

[hsivank@…]

Replying to macsforever2000@…:

Did you get qt4-mac +cocoa to compile on Snow Leopard? Did you modify the portfile?

Yes, I use Qt 4.7 (4.6 trunk version)

Maybe we can update qt-mac-devel port with Qt 4.6 ... there is a stable branch : ​http://qt.gitorious.org/qt/qt/commits/4.6-stable

I think it should build with Snow Leopard with 2~3 patches

It can be a Temporary workaround ...

What is your opinion ?

[hsivank@…]

Some patches to control the dock icon with Qt. it should work with Qt, cocoa or carbon, 32 or 64 bit

[mf2k (Frank Schima)]

Replying to hsivank@…:

Replying to macsforever2000@…:

Did you get qt4-mac +cocoa to compile on Snow Leopard? Did you modify the portfile?

Yes, I use Qt 4.7 (4.6 trunk version)

Maybe we can update qt-mac-devel port with Qt 4.6 ... there is a stable branch : ​http://qt.gitorious.org/qt/qt/commits/4.6-stable

I think it should build with Snow Leopard with 2~3 patches

It can be a Temporary workaround ...

What is your opinion ?

Please attach your qt4-mac(-devel) portfile. Yes, that port should be updated to something that can work in Snow Leopard.

[mnick@…]

I currently don't have access to 10.6, so unfortunatly i can't test this. I would be glad if anyone with 10.6 can take a look at this.

[hsivank@…]

Please attach your qt4-mac(-devel) portfile. Yes, that port should be updated to something that can work in Snow Leopard.

Hello, sorry for the delay I didn't see your request

I use a git style fetch because the tar.gz provide by ​http://qt.gitorious.org/qt/qt is corrupted :-(

But there is a problem :

when i try to install the port with an url like ​git://.... it hangs up

sudo port -vd install qt4-mac-devel +noqt3support +cocoa
...
--->  Fetching qt4-mac-devel
DEBUG: Executing org.macports.fetch (qt4-mac-devel)
DEBUG: Executing: /opt/local/bin/git clone -q --depth=1 git://git.gitorious.org/qt/qt.git /opt/local/var/macports/build/_opt_ports.git_dports_aqua_qt4-mac-devel/work/qt4-mac-devel-4.6.0 2>&1
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
Error: Target org.macports.fetch returned: Git clone failed
DEBUG: Backtrace: Git clone failed
    while executing
"gitfetch"
    (procedure "portfetch::fetch_main" line 13)
    invoked from within
"$procedure $targetname"
Warning: the following items did not execute (for qt4-mac-devel): org.macports.activate org.macports.fetch org.macports.extract org.macports.checksum org.macports.patch org.macports.configure org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.

Note git clone ​git:// works in a terminal !

when i try with an url like ​http:// it works but gitorious.org provides a very low bandwitch ... so i don't think it is interesting for a backend user to wait 2 hours to clone qt-mac ...

If someone have a solution ... i'm very curious to understand

Anyway, i post my patch to build Qt 4.6 with Snow leopard

[hsivank@…]

I configure Qt with :

./configure -arch x86_64 -release -confirm-license -opensource -prefix /opt/local/libexec/qt4-mac/ -docdir /opt/local/share/doc/qt4-mac/ -examplesdir /opt/local/share/qt4-mac/examples/ -demosdir /opt/local/libexec/qt4-mac/demos -system-sqlite -openssl-linked -L/opt/local/lib -fast -no-qt3support -v -sdk /Developer/SDKs/MacOSX10.6.sdk/ -cocoa

If an error occurs with something like 'struct WebCore::Event' it is an include clash with /opt/local/include/event.h

Note : i use master branch from ​git://gitorious.org/qt/qt.git

[hsivank@…]

Replying to mnick@…:

I currently don't have access to 10.6, so unfortunatly i can't test this. I would be glad if anyone with 10.6 can take a look at this.

The result is not very nice with a big magnifying glass on the dock. The better way would be to rewrite a tray class with cocoa API ...

[mf2k (Frank Schima)]

Cc Me!

[markus@…]

Cc Me!

[lagrave+bugs+macosforge.org@…]

Cc Me!

[aleksey.ovcharenko@…]

Replying to hsivank@…:

Replying to mnick@…:

I currently don't have access to 10.6, so unfortunatly i can't test this. I would be glad if anyone with 10.6 can take a look at this.

The result is not very nice with a big magnifying glass on the dock. The better way would be to rewrite a tray class with cocoa API ...

Just replace definition in patch to use bigger (128x128) icons instead of 48x48 as in original patch and you will be nice Dock icons again:

sed -i.bak 's,48x48,128x128,' patch-src-vidalia-mainwindow.cpp.diff

[hsivank@…]

Fix integrated into Vidalia : ​http://trac.vidalia-project.net/changeset/4227

Next release of Vidalia will be ok for Snow Leopard !

[mnick@…]

Committed the official patch in r64480. Thanks!