llvm, llvm-devel: use --disable-assertions and --disable-expensive-checks

[ryandesign (Ryan Carsten Schmidt)]

Could you please update the llvm and llvm-devel ports to add the configure args --disable-assertions and --disable-expensive-checks? Albert Graef, the author of the ​Pure language which uses llvm, ​says these options are beneficial:

From: Albert Graef <Dr.Graef@…>
Date: September 6, 2009 19:13:22 CDT
To: pure-lang@…
Subject: [pure-lang] Re: ANN: Pure 0.33
Reply-To: pure-lang@…

You should really consider to always add --disable-assertions and --disable-expensive-checks, because leaving these options enabled is a major performance hog in both the IR builder and the JIT. Even worse, --enable-expensive-checks makes Pure hit some bogus assertions in LLVM

2.6. I hear that other LLVM applications have issues with these

options, too, and anyway they shouldn't be needed unless you want to hunt down bugs in LLVM itself.

[erickt@…]

Committed, finally! Sorry for the delay.

[ryandesign (Ryan Carsten Schmidt)]

I see you added --disable-assertions to llvm in r60440 but did not add --disable-expensive-checks and did not modify llvm-devel. If that was intentional, could you explain?

[erickt@…]

I followed what fedora did for their llvm options. I can add it as a variant though if you'd like.

And I forgot to update llvm-devel. I'll try to do that now.

[erickt@…]

Ack, I forgot, disable-expensive-checks is the default. I re-enabled pic, so you should be good to go.