Opened 15 years ago
Closed 15 years ago
#21641 closed submission (fixed)
meschach 1.2b-1 package
Reported by: | howarth@… | Owned by: | mf2k (Frank Schima) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
Port: | meschach |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
The attached packaging provides a meschach library of vector and matrix routines for use by the Pynmr plugin. The meschach cvs snapshot tarball and patches from the debian meschach package are used to insure the eliminate all known bugs and solve build issues against the current devtools.
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
Description: | modified (diff) |
---|
comment:2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|
comment:3 Changed 15 years ago by howarth@…
Made requested changes except that branch and major are hardcoded since version has a non-numeric character (1.2b).
comment:4 Changed 15 years ago by howarth@…
Can we get this package into the 1.8.1 ports so that we can get pynmr in as well? There should be no remaining issues with the meschach packaging.
comment:5 Changed 15 years ago by howarth@…
Ping. Can we get this packaging committed so that the
pynmr package that requires it can go as well?
Thanks in advance.
comment:6 Changed 15 years ago by mf2k (Frank Schima)
Owner: | changed from macports-tickets@… to macsforever2000@… |
---|---|
Status: | new → assigned |
comment:7 Changed 15 years ago by mf2k (Frank Schima)
Keywords: | math removed |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Version: | 1.8.0 |
Note: See
TracTickets for help on using
tickets.
I have several concerns about the files you submitted.
In the Portfile:
The initial revision of any given version should be 0, not 1. To achieve this, you can write "revision 0" or omit the revision line entirely.
You may want to obfuscate your email address by writing "maintainers bromo.med.uc.edu:howarth"
You should avoid hardcoding version numbers in portfiles. In this case, you should use "distfiles ${name}_${version}.orig.tar.gz" so that you don't need to keep changing this line with every version update.
You don't need to keep repeating the filename before each checksum type; it's only needed before the first one in the set. You also misspelled "rmd160" for the patchfile's checksums. So I suggest writing:
I don't mind hardcoding the version number in the name of the patchfile, because such a patchfile is obviously meant to be specific to this version anyway.
In the destroot phase:
You do not need to make this directory; MacPorts makes this and many other common directories for you.
You should not hardcode the version number here. Compute it based on the ${version} variable. We commonly use a variable called ${branch} to indicate the value "1.2" in this case, and a variable called ${major} to indicate the value "1". See PortfileRecipes.
Does "make torture" compile something? If so, this should happen in the post-build phase, not the destroot.
For both "make torture" and "./torture", these assume something about the current working directory. MacPorts does not guarantee what the current working directory will be, so you should "cd" to where you want to be before each of these commands. In the post-build: 'system "cd ${worksrcpath} && make torture"'. In the destroot: 'system "cd ${worksrcpath} && ./torture"'.
In the patchfile:
Instead of hardcoding parts of the version number, it would be better to reinplace it with the ${version}, ${branch} and ${major} variables in the portfile, or make use of the $(vers) makefile variable I see there.
This change seems suspicious, and since the comment above it says this target is only used for PC machines, it seems unnecessary to touch this area.
These hunks seem unnecessary, since they only deal with cleanup routines, and MacPorts cleans up for you.