Opened 15 years ago

Closed 6 years ago

#21862 closed defect (worksforme)

Unison +aqua fails to build on the 64-bit system

Reported by: kiyoshi.coquser@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: Cc: mirimiri66@…, kenyon@…, cooljeanius (Eric Gallager), neukomp@…, Polyergic (Shad Sterling), MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Port: unison

Description

Unison aqua variant fails to build on the 64-bit system because it is not 64-bit clean.

I built minimal patch to fix this issue.

This patch and fixed ocaml (Ticket #21743) will make Unison +aqua also work on the 64-bit system.

NOTE:

  1. This patch upgrades Unison from 2.27.57 to 2.32.52, and they CAN NOT synchronize files with each other.

To avoid the confusion about connection failure, It my be as well to create an new port with different name like "unison-2.32".

  1. This is not the official patch. this issue will be fixed smarter way at the future version of Unison.

Attachments (5)

unison-patch.tar.bz2 (11.9 KB) - added by kiyoshi.coquser@… 15 years ago.
patch files
unison.tar.bz2 (12.0 KB) - added by kiyoshi.coquser@… 15 years ago.
unison-2.27.157 with 64-bit clean aqua variant
unison-2.32.tar.bz2 (12.0 KB) - added by kiyoshi.coquser@… 15 years ago.
unison-2.32.52 with 64-bit clean +aqua variant
Portfile (2.1 KB) - added by cssdev 15 years ago.
unison-devel port from Unison r390
unison-devel.tar.bz2 (852.6 KB) - added by kiyoshi.coquser@… 15 years ago.
64-bit support patch of Unision svn r390

Download all attachments as: .zip

Change History (26)

Changed 15 years ago by kiyoshi.coquser@…

Attachment: unison-patch.tar.bz2 added

patch files

comment:1 Changed 15 years ago by tobypeterson

Owner: changed from macports-tickets@… to eridius@…

comment:2 Changed 15 years ago by jmroot (Joshua Root)

Port: unison added

comment:3 Changed 15 years ago by cssdev

The attached changes seems to work for me.

comment:4 Changed 15 years ago by kiyoshi.coquser@…

I re-built two unison ports for unison-2.27.157 and 2.32.52.

Aqua variant of them are 64-bit clean.

NOTE:

Unison-2.27.157 and unison-2.27.57 (current unison port version) can synchronize files each other.

Growl notification is comment outed.

Changed 15 years ago by kiyoshi.coquser@…

Attachment: unison.tar.bz2 added

unison-2.27.157 with 64-bit clean aqua variant

Changed 15 years ago by kiyoshi.coquser@…

Attachment: unison-2.32.tar.bz2 added

unison-2.32.52 with 64-bit clean +aqua variant

comment:5 Changed 15 years ago by cssdev

Does the recent commit to Unison's svn r389 improve things? Perhaps a separate unison-devel port could build against this revision?

fetch.type        svn
svn.url           https://webdav.seas.upenn.edu/svn/unison/trunk/
svn.tag           389
worksrcdir        trunk

comment:6 Changed 15 years ago by kiyoshi.coquser@…

Please tell me what is a problem about the patches I proposed?

I will try to fix it.

Discommunication between unison-2.27.x and unison-2.32.x is not a issue.

Unision is implemented as such a way.

Please read the description around the keywords "unexpected header" on the page:

http://alliance.seas.upenn.edu/~bcpierce/wiki/index.php?n=Main.UnisonFAQTroubleshooting

Anyway, I will try to build unison-devel port from svn latest one.

Changed 15 years ago by cssdev

Attachment: Portfile added

unison-devel port from Unison r390

comment:7 Changed 15 years ago by cssdev

The aqua variants don't seem to build for either 389 or 390. Should I just commit only the command line version?

comment:8 Changed 15 years ago by kiyoshi.coquser@…

Committing command line version of r390 is good idea, I think.

I am now trying to build a 64-bit support patch for r390, but It will take a bit more time.

So, please commit command line version, no need to care my try.

comment:9 Changed 15 years ago by kiyoshi.coquser@…

64-bit version of unison r390 with +aqua (macnew09) is now work on Snow Leopard.

My patch is not well tested, so please use it carefully.

NOTE: The icon of Unison.app looks just like a icon of /System/Library/Core Services/File Sync.app. I am afraid that it may infringe a copyright.

comment:10 Changed 15 years ago by kiyoshi.coquser@…

I'm sorry, previous archive was composed from my working copy with a bug. Please try new one.

Changed 15 years ago by kiyoshi.coquser@…

Attachment: unison-devel.tar.bz2 added

64-bit support patch of Unision svn r390

comment:11 Changed 15 years ago by mirimiri66@…

Cc: mirimiri66@… added

Cc Me!

comment:12 Changed 14 years ago by jmroot (Joshua Root)

Owner: changed from eridius@… to macports-tickets@…

comment:13 Changed 14 years ago by l2g@…

Owner: changed from macports-tickets@… to l2g@…

comment:14 Changed 12 years ago by kenyon@…

Cc: kenyon@… added

Cc Me!

comment:15 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:16 Changed 11 years ago by neukomp@…

Cc: neukomp@… added

Cc Me!

comment:17 Changed 11 years ago by Polyergic (Shad Sterling)

Cc: me@… added

Cc Me!

comment:18 Changed 10 years ago by mf2k (Frank Schima)

Owner: changed from l2g@… to macports-tickets@…

This port is no longer maintained. See #44276.

comment:19 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: MarcusCalhoun-Lopez added

comment:20 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

The Unison port has undergone significant changes since this bug report was reported.
64-bit builds no longer seem to be a problem.
If this is not the case, please feel free to reopen.

comment:21 Changed 6 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: worksforme
Status: newclosed
Note: See TracTickets for help on using tickets.