java/pmd 3.9 fails to build

[champlin@…]

Mac OS X 10.5.8 / Xcode 3.1.3

I apologize because this is really a followup to ticket #16649 but I don't know how to resurrect it. It was closed 6 months ago with no obvious resolution but the problem persists. Basically, PMD requires jUnit to run some test cases during its build. It fails because junit.jar isn't on its classpath, though you may have the junit port installed. A similar problem was solved in the java/commons-logging port (r33902) and I've attached a diff reflecting their solution for pmd. Here is an abbreviated sample of my original installation attempt illustrating the problem:

boris[1004] sudo port install pmd
--->  Computing dependencies for pmd
--->  Fetching pmd
--->  Attempting to fetch pmd-src-3.9.zip from http://internap.dl.sourceforge.ne
t/pmd
--->  Verifying checksum(s) for pmd
--->  Extracting pmd
--->  Configuring pmd
--->  Building pmd
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/ma
cports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_ja
va_pmd/work/pmd-3.9/bin" && ant dist " returned error 1
Command output:     [javac]                        ^
    [javac] /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.
macports.org_release_ports_java_pmd/work/pmd-3.9/regress/test/net/sourceforge/pm
d/symboltable/TypeSetTest.java:14: cannot find symbol
    [javac] symbol: class TestCase
    [javac] public class TypeSetTest extends TestCase {
    [javac]                                  ^
    [javac] /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.
macports.org_release_ports_java_pmd/work/pmd-3.9/regress/test/net/sourceforge/pm
d/symboltable/VariableUsageFinderFunctionTest.java:3: package junit.framework do
es not exist
    [javac] import junit.framework.TestCase;
    [javac]                        ^
...

Thank you very much. -virgil

[champlin@…]

PMD Portfile unified diff

[jmroot (Joshua Root)]

#16649 is not closed...

[champlin@…]

Replying to jmr@…:

#16649 is not closed...

Thank you for correcting my mistake. -virgil