xorg-server 1.7.1.901 not compiling on Tiger (10.4.11)

[rbubley]

Based on source r60346, I get the following error:

Warning: Skipping upgrade since gzip 1.3.12_0 >= gzip 1.3.12_0, even though installed variants "+darwin_8" do not match "". Use 'upgrade --enforce-variants' to switch to the requested variants.
--->  Computing dependencies for xorg-server
--->  Fetching xorg-server
--->  Verifying checksum(s) for xorg-server
--->  Extracting xorg-server
--->  Applying patches to xorg-server
--->  Configuring xorg-server
--->  Building xorg-server
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_x11_xorg-server/work/xorg-server-1.7.1.901" && /usr/bin/nice -n 11 /usr/bin/make -j3 all " returned error 2
Command output: Making all in .
 CC    miinitext.o
 CC    fbcmap_mi.o
 CC    X11Application.o
 CC    X11Controller.o
 CC    applewm.o
 CC    darwin.o
 CC    darwinEvents.o
 CC    darwinXinput.o
 CC    keysym2ucs.o
 CC    pseudoramiX.o
 CC    quartz.o
 CC    quartzAudio.o
 CC    quartzCocoa.o
 CC    quartzKeyboard.o
 CC    quartzStartup.o
quartzKeyboard.c: In function 'DarwinKeyboardReloadHandler':
quartzKeyboard.c:409: warning: implicit declaration of function 'access'
quartzKeyboard.c:409: warning: nested extern declaration of 'access'
quartzKeyboard.c:409: error: 'F_OK' undeclared (first use in this function)
quartzKeyboard.c:409: error: (Each undeclared identifier is reported only once
quartzKeyboard.c:409: error: for each function it appears in.)
quartzKeyboard.c: In function 'QuartzReadSystemKeymap':
 CC    threadSafety.o
quartzKeyboard.c:648: warning: unused variable 'currentKeyLayoutDataRef'
make[3]: *** [quartzKeyboard.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

Error: Unable to upgrade port: 1

[blb@…]

Cc reporter of dup #22447.

[jeremyhu (Jeremy Huddleston Sequoia)]

Can you add '#include <unistd.h>' to quartzKeyboard.c and try again. Hopefully that's the only tiger build issue, but I'd rather make one fix than multiple.

[sschober@…]

Cc Me!

[sschober@…]

I would like to help, but can't figure out how to make that change without having 'port build xorg-server' overriding my changes...

[sschober@…]

Okay, I added unistd.h to the faulting file and the build continued (I invoked make in that dir manually).

But now linking X11.app fails with this:

---8<----
LINK  X11.bin
/usr/bin/ld: warning multiple definitions of symbol _Xalloc
../../../os/.libs/libos.a(utils.o) definition of _Xalloc in section (__TEXT,__text)
/opt/local/lib/libXdmcp.dylib(single module) definition of _Xalloc
/usr/bin/ld: warning multiple definitions of symbol _Xfree
../../../os/.libs/libos.a(utils.o) definition of _Xfree in section (__TEXT,__text)
/opt/local/lib/libXdmcp.dylib(single module) definition of _Xfree
/usr/bin/ld: warning multiple definitions of symbol _Xrealloc
../../../os/.libs/libos.a(utils.o) definition of _Xrealloc in section (__TEXT,__text)
/opt/local/lib/libXdmcp.dylib(single module) definition of _Xrealloc
/usr/bin/ld: Undefined symbols:
_glProgramEnvParameters4fvEXT
_glProgramLocalParameters4fvEXT
collect2: ld returned 1 exit status
make[4]: *** [X11.bin] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1
--->8---

But maybe I was missing some arguments 'ports build' is adding? I inspected the Portsfile but didn't find anything special...

[sschober@…]

Add unistd.h to quartzKeyboard.c

[sschober@…]

Ok, putting your hint in a patch and adding it to

/opt/local/var/macports/sources/rsync.macports.org/release/ports/x11/xorg-server/Portfile

helped. :) Sorry for the noise, btw...

[jeremyhu (Jeremy Huddleston Sequoia)]

I'm confused. Are you still getting linking errors for: _glProgramEnvParameters4fvEXT _glProgramLocalParameters4fvEXT

That should be fixed with this hunk in indirect.c:

/* Tiger PPC doesn't have the associated symbols, but glext.h says it does.  Liars!
 * http://trac.macports.org/ticket/20638
 */
#if defined(__ppc__) && MAC_OS_X_VERSION_MIN_REQUIRED == 1040
#undef GL_EXT_gpu_program_parameters
#define GL_EXT_gpu_program_parameters 0
#endif

Are you on intel?

[sschober@…]

I'm on ppc and in my last comment i tried to communicate that the linking errors seemed to have been my fault (invoking 'make' manually instead of creating a patch and invoking 'port build'). So, no i don't get linking errors anymore :) Thanks!

[rbubley]

Works for me too. (On Intel)

[jeremyhu (Jeremy Huddleston Sequoia)]

r60429