rsync @3.0.7 does not preserve creation date when built for 64-bit

[philipp@…]

Discovered with backup bouncer that creation times are not preserved using the latest rsync 3.0.6 from macports.

Used rsync options: -aNHAXxv --fileflags --force-change --delete --delete-excluded

Output below is directly from backup bouncer:

------------------ rsync-macports ------------------
Verifying:    basic-permissions ... ok (Critical)
Verifying:           timestamps ... ok (Critical)
Verifying:             symlinks ... ok (Critical)
Verifying:    symlink-ownership ... ok 
Verifying:            hardlinks ... ok (Important)
Verifying:       resource-forks ... 
   Sub-test:             on files ... ok (Critical)
   Sub-test:  on hardlinked files ... ok (Important)
Verifying:         finder-flags ... ok (Critical)
Verifying:         finder-locks ... ok 
Verifying:        creation-date ... FAIL 
Verifying:            bsd-flags ... ok 
Verifying:       extended-attrs ... 
   Sub-test:             on files ... ok (Important)
   Sub-test:       on directories ... ok (Important)
   Sub-test:          on symlinks ... ok 
Verifying: access-control-lists ... 
   Sub-test:             on files ... ok (Important)
   Sub-test:              on dirs ... ok (Important)
Verifying:                 fifo ... ok 
Verifying:              devices ... ok 
Verifying:          combo-tests ... 
   Sub-test:  xattrs + rsrc forks ... ok 
   Sub-test:     lots of metadata ... ok 

[philipp@…]

Cc Me!

[nerdling (Jeremy Lavergne)]

This appears to be ​a known bug upstream.

[nerdling (Jeremy Lavergne)]

Their conclusion:

crtimes patch does not work when rsync 3.0.6-pre1 (and 3.0.5) is compiled for x86_64 and run on Core2Duo in 64bit mode on Mac OS X 10.5.6. crtimes patch does only work when rsync is compiled in 32bit mode (i386) or for any PPC build.

The maintainer might consider enabling build_arch=i386 for this port if os.major > 9.

[858wildcat@…]

Cc Me!

[macports@…]

​https://bugzilla.samba.org/show_bug.cgi?id=6276

A fix was created for this. I had to apply it to 3.0.7 as well.

[faisal.moledina@…]

I just verified with backup bouncer 0.2.0 that creation times with rsync 3.0.7 are not preserved without the 64-bit patch from the rsync Bugzilla. What is the status of including this in the portfile? Using instructions at the ​Bombich site, I downloaded the patch using

curl -o files/patch-crtimes-64bit.diff https://bugzilla.samba.org/attachment.cgi?id=5288

in my local dports/net/rsync dir. I added it to the Portfile in the patchfiles section and it built successfully and the resulting rsync preserved creation times, along with everything else.

[faisal.moledina@…]

Cc Me!

[jmroot (Joshua Root)]

r75561