muniversal group: merge .la dependency_libs value

[pguyot (Paul Guyot)]

.la files are automatically generated text files that contain linking information. muniversal group fails if two .la files differ.

However, it seems we could apply some heuristics, for example with the dependency_libs key.

i386 and x86_64 libgettextlib.la files are identical except for the following line:

# Libraries that this one depends upon.
dependency_libs=' /opt/local/lib/libintl.la -L/opt/local/lib -lc -ltermcap'

# Libraries that this one depends upon.
dependency_libs=' -R/opt/local/lib /opt/local/lib/libintl.la -L/opt/local/lib -lc /opt/local/lib/libiconv.la -lncurses'

That these lines could probably be merged by putting every item in each, and that wouldn't create a problem. The attached patch does just this and allows gettext +universal to be built on 10.6.

The patch could be extended to process inherited_linker_flags as well (see ticket #22801).

What do you think?

[pguyot (Paul Guyot)]

Patch to merge .la files with muniversal group

[ryandesign (Ryan Carsten Schmidt)]

Replying to pguyot@…:

i386 and x86_64 libgettextlib.la files are identical except for the following line:

They are completely identical for me on Snow Leopard. Are you certain your ncurses and ncursesw are built universal for the same architectures as those for which you are now trying to build gettext?

[pguyot (Paul Guyot)]

Indeed, ncurses and ncursesw were not built +universal.

[ryandesign (Ryan Carsten Schmidt)]

Replying to pguyot@…:

Indeed, ncurses and ncursesw were not built +universal.

That specific problem should be addressed by #22876. I am worried about applying your proposed change to the muniversal portgroup, because differences in .la files are often caused by dependencies that are not built universal, and we don't want to mask that problem.

[ryandesign (Ryan Carsten Schmidt)]

This issue should be solved due to #38010 (dependency_libs will now be removed from all ports).

[cooljeanius (Eric Gallager)]

Cc Me!