Opened 15 years ago

Closed 15 years ago

#22950 closed update (fixed)

asterisk-1.6.1.12

Reported by: stefan.van.der.eijk@… Owned by: marc.blanchet@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: mr_bond@…, roederja
Port: asterisk

Description

Update to the asterisk port, to 1.6.1.12.

Attachments (1)

asterisk.diff (1.8 KB) - added by stefan.van.der.eijk@… 15 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 15 years ago by mf2k (Frank Schima)

Cc: mr_bond@… added
Keywords: haspatch added
Owner: changed from macports-tickets@… to marc.blanchet@…
Version: 1.8.1

comment:2 Changed 15 years ago by roederja

Cc: jann@… added

You seem to be hardcoding x86_64 as platform. This is bad. Can you please fix this. ${build_arch} will tell you if you need to build for x86_64 or i386 or ppc. But you can also use platform to distinguish between ppc and intel.

Changed 15 years ago by stefan.van.der.eijk@…

Attachment: asterisk.diff added

comment:3 Changed 15 years ago by stefan.van.der.eijk@…

OK, I'll disable building the gsm codec, as this is the part causing the issue. Please review new diff.

comment:4 Changed 15 years ago by roederja

Looks good now, but it shouldn't be too hard to give the correct argument depending on the build platform. Or does the GSM codec only work on x86_64 ?

comment:5 in reply to:  4 Changed 15 years ago by stefan.van.der.eijk@…

Replying to jann@…:

Looks good now, but it shouldn't be too hard to give the correct argument depending on the build platform.

I'd rather not do that. It should just build on all platforms.

Or does the GSM codec only work on x86_64 ?

No, I think there is something wrong with the way the platform selection is done for the GSM codec. When nothing is specified I get the following error on my mac mini (10.6.2):

src/add.c:1: error: CPU you selected does not support x86-64 instruction set

See #20973

I guess the best place to address this is upstream with the Asterisk team at Digium.

comment:6 Changed 15 years ago by roederja

I committed the patch in r62817. Can you talk to the Digium guys? Another thing that I find stange is teh dependency on wget and curl. Is this really required?

comment:7 Changed 15 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.