Opened 15 years ago
Closed 7 years ago
#23177 closed enhancement (fixed)
Some of curl's variants should be rolled into the main port
| Reported by: | danielluke (Daniel J. Luke) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | cooljeanius (Eric Gallager) | |
| Port: | curl |
Description
Since our general policy for ports is to make them as featureful as possible (and reserve variants for things like preventing pulling in huge dependencies), some of the curl variants should probably be included by default.
I would say ssl and ipv6 for sure (with the gnutls variant removing openssl support and adding gnutls support instead since they conflict).
Change History (7)
comment:1 Changed 15 years ago by jmroot (Joshua Root)
| Type: | request → enhancement |
|---|---|
| Version: | 1.8.2 |
comment:2 follow-up: 3 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
| Status: | new → assigned |
|---|
comment:3 Changed 15 years ago by danielluke (Daniel J. Luke)
Replying to ryandesign@…:
Do you think I should remove any of the other variants?
Maybe? If the idn and sftp support don't take long to build you might consider including them (and really the same with gss and openldap, and any of the other ones I guess).
I just noticed ssl/ipv6 recently because I got macports curl as a dependency of something else and some quick hack script I wrote started picking up the new MP curl instead of the system one and was failing ;-)
comment:4 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
idn variant removed and idn support permanently enabled in r63928.
comment:6 Changed 7 years ago by raimue (Rainer Müller)
Is there anything left for this ticket? The +ssl variant is selected by default and IPv6 support is always enabled. The remaining variants require additional dependencies and it seems reasonable to keep them as variants.
comment:7 Changed 7 years ago by danielluke (Daniel J. Luke)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I agree SSL should be on by default, but I don't want to remove the ssl variant. Instead, I will make it a default variant, provided the user has not already selected gnutls.
The request to always include IPv6 was originally made in #17861 (for a whole buncha ports). curl was not updated because at that time a variant (ares) conflicted with the ipv6 variant, but that conflict was apparently spurious and was removed in r53012, so now nothing stands in the way of this change.
The doc variant should also go away and be always included. It's only an additional 1.5MB of files.
The above is done in r62440.
Do you think I should remove any of the other variants?