Opened 15 years ago

Closed 15 years ago

#23325 closed defect (fixed)

clhep config scripts include architectures

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: cristiano.fontana@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: Cc:
Port: clhep

Description

The config scripts clhep installs all have the build architectures in them:

$ clhep-config --ldflags
-L/opt/local/lib -arch x86_64 -arch i386

These should be removed post-build or post-destroot. See the curl and gd2 ports for an example (though they both use the muniversal portgroup; since clhep doesn't, you won't be using [muniversal_get_arch_flag]).

Attachments (1)

Portfile-clhep.diff (212 bytes) - added by cristiano.fontana@… 15 years ago.

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by cristiano.fontana@…

Attachment: Portfile-clhep.diff added

comment:1 Changed 15 years ago by cristiano.fontana@…

I hope that the regex is in the right dialect...

comment:2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Your patch does not work for many reasons:

  • square brackets inside double quotes are interpreted by tcl; you need to either escape square brackets with a backslash or use curly quotes instead of double quotes
  • you need to specify the full path to the files you're reinplacing; do not assume any particular working directory
  • more files than just clhep-config are affected; to see all the files that are affected you can use port contents clhep | sed 1d | xargs grep -- ' -arch '

The above suggests to me you did not test your patch. Please test your patches before submitting them.

You also need to increase the port's revision when making changes that alter the contents of files installed by the port.

I have fixed the issue in r63750.

Note: See TracTickets for help on using tickets.