Opened 15 years ago

Closed 15 years ago

#23511 closed defect (fixed)

git-core: gitweb variant missing gitweb.js

Reported by: dgarnier (reinrag1a) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: haspatch Cc: maccheck@…, bryan@…
Port: git-core

Description (last modified by jmroot (Joshua Root))

At some point, gitweb added a gitweb.js for client side enhancements... The server complains the file is missing. Simple one line add of "gitweb.js" to the portfile.

--- Portfile.old	2010-02-01 13:19:26.000000000 -0500
+++ Portfile	2010-02-01 13:26:40.000000000 -0500
@@ -106,6 +106,7 @@
         xinstall -m 444 -W ${worksrcpath}/gitweb \
             gitweb.cgi \
             gitweb.css \
+            gitweb.js \
             git-favicon.png \
             git-logo.png \
             ${destroot}${prefix}/share/${name}/gitweb

Attachments (1)

git-core.patch (434 bytes) - added by dgarnier (reinrag1a) 15 years ago.
patch file for git-core/Portfile

Download all attachments as: .zip

Change History (8)

Changed 15 years ago by dgarnier (reinrag1a)

Attachment: git-core.patch added

patch file for git-core/Portfile

comment:1 Changed 15 years ago by jmroot (Joshua Root)

Cc: maccheck@… added
Description: modified (diff)
Keywords: haspatch added
Owner: changed from macports-tickets@… to bryan@…
Port: git-core added

Please remember to preview and use WikiFormatting, fill in the Port field, and cc the maintainers.

comment:2 Changed 15 years ago by dgarnier (reinrag1a)

Cc: garnier@… added

Cc Me!

comment:3 Changed 15 years ago by dgarnier (reinrag1a)

Oh... and while you are at it.. you may consider making gitweb.cgi executable by _www... since it needs this to run, at least when using with Apache

comment:4 Changed 15 years ago by maccheck@…

I integrated your patch into the new Portfile version for git-core 1.6.6.2 (see #23666). I'm currently hesitant to update the executable bits of the installed files because I don't know the MacPorts policy for that.

For the time being I would like to stick to manually updating it by the user who needs it...

comment:5 Changed 15 years ago by maccheck@…

Sorry, as #23666 was superseded by r63775 the gitweb.js patch was not included in the last git-core update.

comment:6 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: bryan@… added; garnier@… removed
Owner: changed from bryan@… to ryandesign@…
Status: newassigned
Summary: git-core 1.6.6.1 - gitweb varient missing gitweb.jsgit-core: gitweb variant missing gitweb.js

comment:7 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I agree gitweb.cgi should have the executable bit. That's fixed, and gitweb.js is now being installed, as part of r65174.

Note: See TracTickets for help on using tickets.