cmake portgroup does not set install name directory for libraries

[raphael-st (Raphael Straub)]

The cmake portgroup does not set the install name directory for libraries. This can be set with the parameter

-DCMAKE_INSTALL_NAME_DIR=${prefix}/lib

for cmake, see ​http://www.cmake.org/cmake/help/cmake-2-8-docs.html#prop_tgt:INSTALL_NAME_DIR.

I tested all ports that use the cmake portgroup and found out that some ports install libraries with the wrong install name (physfs, chipmunk, clucene-devel, eigen) and some other ports (bullet, nifticlib, OpenSceneGraph-devel, zorba, orocos-kdl, orocos-rtt, flann) manually use the above parameter or call install_name_tool. The rest either does not need this parameter (taglib, qhull, strigi, wbxml2) or installs no library at all (gccxml-devel, newmat, Vidalia).

I'm not sure, who is responsible for the cmake portgroup. I think, the patch for the cmake portgroup in the attachment can be applied without affecting ports that already use correct install names without this patch.

[jmroot (Joshua Root)]

Portgroups don't officially have specific maintainers. The cmake one was originally written by illogic-al.

[ryandesign (Ryan Carsten Schmidt)]

Once we apply this patch to the cmake portgroup, we would probably want to deal with all the ports that use the cmake portgroup. Those ports that don't currently install libraries with proper install_names should have their revisions bumped so they're rebuilt. Those that have manual workarounds for this should have them removed, assuming the portgroup will do the same thing.

[raphael-st (Raphael Straub)]

I applied the patch to the cmake portgroup in r64576 and bumped the revision of ports that didn't use correct install names in r64577. I also informed all maintainers of cmake portgroup based ports that they can remove their workarounds.

[ryandesign (Ryan Carsten Schmidt)]

Forgot to bump the revision of all the ports using the kde4 portgroup, which uses the cmake portgroup. See for example #23732.

[jmroot (Joshua Root)]

The problem with the portgroup is fixed, and it's kind of late to be rev bumping stuff now.