MPlayer, mplayer-devel don't build with zlib 1.2.4

[ryandesign (Ryan Carsten Schmidt)]

MPlayer doesn't build with zlib 1.2.4:

/usr/bin/gcc-4.0 -I../libavformat -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -I. -I.. -I../libavutil -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=pentium-m -mtune=pentium-m -pipe -ffast-math -fomit-frame-pointer -mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN -shared-libgcc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DHAVE_CONFIG_H -I/opt/local/include/lzo -I/opt/local/include -I/usr/local/include   -c -o vo_png.o vo_png.c
In file included from /opt/local/include/png.h:506,
                 from vo_png.c:15:
/opt/local/include/zlib.h:1561: error: parse error before 'gzseek64'
/opt/local/include/zlib.h:1561: error: parse error before 'off64_t'
/opt/local/include/zlib.h:1561: warning: type defaults to 'int' in declaration of 'gzseek64'
/opt/local/include/zlib.h:1561: warning: data definition has no type or storage class
/opt/local/include/zlib.h:1562: error: parse error before 'gztell64'
/opt/local/include/zlib.h:1562: warning: type defaults to 'int' in declaration of 'gztell64'
/opt/local/include/zlib.h:1562: warning: data definition has no type or storage class
/opt/local/include/zlib.h:1563: error: parse error before 'gzoffset64'
/opt/local/include/zlib.h:1563: warning: type defaults to 'int' in declaration of 'gzoffset64'
/opt/local/include/zlib.h:1563: warning: data definition has no type or storage class
/opt/local/include/zlib.h:1564: error: parse error before 'off64_t'
/opt/local/include/zlib.h:1565: error: parse error before 'off64_t'
make[1]: *** [vo_png.o] Error 1
make: *** [libvo/libvo.a] Error 2

mplayer-devel fails like this:

/usr/bin/gcc-4.2 -Wundef -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -mdynamic-no-pic -falign-loops=16 -shared-libgcc -I. -I/opt/local/include/lzo -I/opt/local/include  -I/usr/X11/include   -c -o libvo/vo_png.o libvo/vo_png.c
In file included from /opt/local/include/png.h:506,
                 from libvo/vo_png.c:33:
/opt/local/include/zlib.h:1561: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzseek64'
/opt/local/include/zlib.h:1562: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gztell64'
/opt/local/include/zlib.h:1563: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzoffset64'
/opt/local/include/zlib.h:1564: error: expected declaration specifiers or '...' before 'off64_t'
/opt/local/include/zlib.h:1565: error: expected declaration specifiers or '...' before 'off64_t'
make: *** [libvo/vo_png.o] Error 1

The general ticket for this zlib 1.2.4 issue is #24067 but my understanding is that this error actually reveals a problem in MPlayer and mplayer-devel which is where the fix needs to occur.

[stvnschwrz@…]

Cc Me!

[stvnschwrz@…]

In addition, the gnome-vfs port won't build against zlib 1.2.4 either:

In file included from gzip-method.c:33:
/opt/local/include/zlib.h:1561: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzseek64'
/opt/local/include/zlib.h:1562: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gztell64'
/opt/local/include/zlib.h:1563: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzoffset64'
/opt/local/include/zlib.h:1564: error: expected declaration specifiers or '...' before 'off64_t'
/opt/local/include/zlib.h:1565: error: expected declaration specifiers or '...' before 'off64_t'

Should I open a separate ticket for this case?

[ryandesign (Ryan Carsten Schmidt)]

Yes, please.

[stvnschwrz@…]

Ok, done, see #24083.

[dershow]

Cc Me!

[zquestz (Josh Ellithorpe)]

To fix, just remove -D_LARGEFILE64_SOURCE from config.mak after it fails. Quick workaround till the port is updated.

[bhadder@…]

Cc Me!

[jsg72@…]

Cc Me!

[mirimiri66@…]

Cc Me!

[bitmail@…]

Cc Me!

[ben-macports@…]

Cc Me!

[alek2@…]

Cc Me!

[social.thiago@…]

Cc Me!

[jmroot (Joshua Root)]

Well, apparently nobody here is going to do anything about this (not surprising given that zlib 1.2.5 doesn't exhibit the problem), and it's really something that upstream should deal with anyway.