Opened 15 years ago

Closed 15 years ago

#24165 closed enhancement (fixed)

gearmand: use startupitem.executable

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: rodney.rehm@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: Cc:
Port: gearmand

Description

In the gearmand portfile you submitted in #24158, you use startupitem.start and startupitem.stop. It is preferable to use startupitem.executable instead if at all possible, as explained in the guide. Could you check whether gearmand still works (starts correctly with port load gearmand and stops correctly with port unload gearmand) with the attached patch? (It seems to for me.) If so, I'll be happy to commit it.

Attachments (1)

gearmand-startupitem.diff (1.1 KB) - added by ryandesign (Ryan Carsten Schmidt) 15 years ago.
proposed patch

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: gearmand-startupitem.diff added

proposed patch

comment:1 Changed 15 years ago by rodney.rehm@…

  1. patched the Portfile with the given diff,
  2. sudo port unload gearmand
  3. sudo port deactivate gearmand
  4. sudo portindex
  5. sudo port install gearmand
  6. sudo port load gearmand
  7. ran test scripts through gearman -> working fine

Looks like your startupitem patch works for me, too. :)

comment:2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Great! Committed in r65182.

Note: See TracTickets for help on using tickets.