Opened 20 years ago

Closed 20 years ago

Last modified 19 years ago

#2438 closed defect (fixed)

bin dependencies should ensure that the files they find are executable.

Reported by: jberry@… Owned by: pguyot (Paul Guyot)
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc:
Port:

Description

Currently bin: dependencies are fooled if they find files or symlinks that are invalid or not executable.

Enclosed patch fixes this issue by ensuring that only executable files are matched in the path search for bin dependencies.

Attachments (1)

patch-darwinports.tcl (1.3 KB) - added by jberry@… 20 years ago.
Patch to base/src/darwinports1.0/darwinports.tcl

Download all attachments as: .zip

Change History (4)

Changed 20 years ago by jberry@…

Attachment: patch-darwinports.tcl added

Patch to base/src/darwinports1.0/darwinports.tcl

comment:1 Changed 20 years ago by pguyot (Paul Guyot)

Owner: changed from darwinports-bugs@… to pguyot@…

comment:2 Changed 20 years ago by pguyot (Paul Guyot)

Status: newassigned

I just don't like the idea of passing an option as a parameter much, plus it's wrong to test that the file is readable (why would a path dependency require a file to be readable? it could just be executable and not readable) and the exists test is just a waste of time.

So I replaced that with an executable option with a default value of 0.

comment:3 Changed 20 years ago by pguyot (Paul Guyot)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.