portchecksum.tcl not reporting correct checksum

[jberry@…]

With Paul's revision to support sha1, we seem to have lost the ability for the code to report at verbose level what the correct checksum should have been. That was a useful feature for building Portfiles and/ or updating correct checksums.

I revised the code as follows: (patch is attached)

• Refactor checksum calculators check_md5 and check_sha1 as calc_md5 and calc_sha1. They now

simply calculate the appropriate type of checksum and return it. The calling code does the actual checksum verification and thus has the "correct" checksum to report at verbose level.

• Don't bail from checksum checking loop on first error. Thus if there are multiple checksums, all

checksum errors will be reported. This makes it easier/faster to set multiple checksums at once.

[jberry@…]

patch to base/src/port1.0/portchecksum.tcl

[jberry@…]

patch to base/src/port1.0/portchecksum.tcl

[pguyot (Paul Guyot)]

Committed. Thanks James.