webkit-gtk-1.1.15.4 build failure with gtk2+quartz - can't find gdk/gdkx.h

[khepler]

webkit-gtk build fails with the following error:

  CXX    WebCore/plugins/gtk/libWebCore_la-PluginViewGtk.lo
WebCore/plugins/gtk/PluginViewGtk.cpp:64:22: error: gdk/gdkx.h: No such file or directory
WebCore/plugins/gtk/PluginViewGtk.cpp: In member function 'NPError WebCore::PluginView::getValue(NPNVariable, void*)':
WebCore/plugins/gtk/PluginViewGtk.cpp:327: error: 'GDK_DISPLAY' was not declared in this scope
WebCore/plugins/gtk/PluginViewGtk.cpp:385: error: 'GDK_WINDOW_XWINDOW' was not declared in this scope
WebCore/plugins/gtk/PluginViewGtk.cpp: In member function 'bool WebCore::PluginView::platformStart()':
WebCore/plugins/gtk/PluginViewGtk.cpp:477: error: 'GDK_WINDOW_XDISPLAY' was not declared in this scope
WebCore/plugins/gtk/PluginViewGtk.cpp:478: error: 'GDK_VISUAL_XVISUAL' was not declared in this scope
WebCore/plugins/gtk/PluginViewGtk.cpp:480: error: 'GDK_COLORMAP_XCOLORMAP' was not declared in this scope
make[1]: *** [WebCore/plugins/gtk/libWebCore_la-PluginViewGtk.lo] Error 1
make: *** [all] Error 2
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/work/webkit-1.1.15.4" && /usr/bin/make -j1 all " returned error 2
Warning: the following items did not execute (for webkit-gtk): org.macports.destroot org.macports.build
Error: Unable to upgrade port: 1
Before reporting a bug, first run the command again with the -d flag to get complete output.

I believe gdk/gdkx.h is installed when gtk2 is built with +x11, but I prefer +quartz and they're mutually exclusive.

OSX 10.5.8 PPC
XCode 3.1.2

[Vertigo:~] dobbs% port dependents webkit-gtk
gimp2 depends on webkit-gtk
[Vertigo:~] dobbs% 

The following ports are currently installed:
gimp2 @2.6.8_1+darwin_9+help_browser+no_x11+quartz (active)
gtk2 @2.18.8_0+no_x11+quartz (active)
webkit-gtk @r30707_1 (active)

The following installed ports are outdated:
webkit-gtk                     r30707_1 < 1.1.15.4_0

Working around by removing +help_browser from gimp2.

[jmroot (Joshua Root)]

Bare usernames do not work in the cc field; you have to use full email addresses.

[elelay (Eric Le Lay)]

Cc Me!

[elelay (Eric Le Lay)]

I managed to have it build, given 2 patches and a couple of configure parameters (see attached files). I'm not quite sure of the consequences yet : I would say that it breaks plugins.

I also updated to the latest version : 1.2.0.

The example browser (./Program/GtkLauncher) works perfectly for me.

[elelay (Eric Le Lay)]

disable all this file

[elelay (Eric Le Lay)]

disable some functions

[elelay (Eric Le Lay)]

add quartz variant

[kitovyj@…]

Cc Me!

[kitovyj@…]

Replying to elelay@…:

I also updated to the latest version : 1.2.0. The example browser (./Program/GtkLauncher) works perfectly for me.

Hi, I've installed current mac ports webkit-gtk version(1.1.x.x) with your patches, and webkit widget works in my application except images. Instad of images black squares are displayed. Does webkit-gtk +quartz displays images in your case? May be I need to download version 1.2 of webkit-gtk to ge it working with your patches? Btw I can't find compiled gtk-launcher in my webkit-gtk installation, does not macports compile it automatically?

[elelay (Eric Le Lay)]

Replying to kitovyj@…:

yes images work for me in webkit-gtk 1.2.0 (both GtkLauncher and in a python app). Do you have any reason to stick to 1.1.x.x ?

Unfortunately, GtkLauncher is built but not installed, so you'll have to

sudo port build -n -f -d webkit-gtk +quartz

and run it from command-line

/opt/local/var/macports/build/SOMETHING_webkit-gtk/work/webkit-1.2.0/Programs/GtkLauncher

cheers,

[kitovyj@…]

Thank you very much for your help. However, I can't get images working even in GtkLauncher. But now I'am having another problem : I did "port upgrade outdated", applied your patch and now webkit-gtk does not built at all. Log shows next errors:

:info:build CXX WebCore/platform/gtk/libwebkit_1_0_la-MIMETypeRegistryGtk.lo :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h: In function 'int istype_l(darwin_ct_rune_t, long unsigned int, _xlocale*)': :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:47: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h: In function 'darwin_ct_rune_t toupper_l(darwin_ct_rune_t, _xlocale*)': :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:54: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h: In function 'darwin_ct_rune_t tolower_l(darwin_ct_rune_t, _xlocale*)': :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:61: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope :info:build make[1]: * [WebCore/platform/gtk/libwebkit_1_0_la-LocalizedStringsGtk.lo] Error 1 :info:build make: * [all] Error 2 :info:build shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/work/webkit-1.2.0" && /usr/bin/make -j2 all " returned error 2 :error:build Target org.macports.build returned: shell command failed :debug:build Backtrace: shell command failed

while executing

"command_exec build"

(procedure "portbuild::build_main" line 8) invoked from within

"$procedure $targetname" :info:build Warning: the following items did not execute (for webkit-gtk): org.macports.activate org.macports.build org.macports.destroot org.macports.install :notice:build Log for webkit-gtk is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/main.log

Don't know if it has some relation with quartz variant of webkit-gtk. Have not you encountered such a problem? By the way, I also disabled the application of patch-WebKitTools-DumpRenderTree-gtk-TestNetscapePlugin-TestNetscapePlugin.cpp.diff patch in portfile, because of errors produced by its application.

Replying to elelay@…:

Replying to kitovyj@…:

yes images work for me in webkit-gtk 1.2.0 (both GtkLauncher and in a python app). Do you have any reason to stick to 1.1.x.x ?

Unfortunately, GtkLauncher is built but not installed, so you'll have to

sudo port build -n -f -d webkit-gtk +quartz

and run it from command-line

/opt/local/var/macports/build/SOMETHING_webkit-gtk/work/webkit-1.2.0/Programs/GtkLauncher

cheers,

[kitovyj@…]

Sorry for not using formatting, here is readable error log:

:info:build   CXX    WebCore/platform/gtk/libwebkit_1_0_la-MIMETypeRegistryGtk.lo
:info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h: In function 'int __istype_l(__darwin_ct_rune_t, long unsigned int, _xlocale*)':
:info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:47: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
:info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h: In function '__darwin_ct_rune_t __toupper_l(__darwin_ct_rune_t, _xlocale*)':
:info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:54: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
:info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h: In function '__darwin_ct_rune_t __tolower_l(__darwin_ct_rune_t, _xlocale*)':
:info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:61: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
:info:build make[1]: *** [WebCore/platform/gtk/libwebkit_1_0_la-LocalizedStringsGtk.lo] Error 1
:info:build make: *** [all] Error 2
:info:build shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/work/webkit-1.2.0" && /usr/bin/make -j2 all " returned error 2
:error:build Target org.macports.build returned: shell command failed
:debug:build Backtrace: shell command failed
    while executing
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
:info:build Warning: the following items did not execute (for webkit-gtk): org.macports.activate org.macports.build org.macports.destroot org.macports.install
:notice:build Log for webkit-gtk is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/main.log}}}



Replying to [comment:6 elelay@…]:
> Replying to [comment:5 kitovyj@…]:
> 
> yes images work for me in webkit-gtk 1.2.0 (both GtkLauncher and in a python app).
> Do you have any reason to stick to 1.1.x.x ?
> 
> Unfortunately, GtkLauncher is built but not installed, so you'll have to 
> {{{
> sudo port build -n -f -d webkit-gtk +quartz
> }}}
> 
> and run it from command-line
> {{{
> /opt/local/var/macports/build/SOMETHING_webkit-gtk/work/webkit-1.2.0/Programs/GtkLauncher
> }}}
> 
> cheers,

[hujingzhe@…]

Cc Me!

[boltronics@…]

Cc Me!

[yaseppochi (Stephen J. Turnbull)]

Replying to kitovyj@…:

But now I'am having another problem : I did "port upgrade outdated", applied your patch and now webkit-gtk does not built at all. Log shows next errors:

:info:build CXX WebCore/platform/gtk/libwebkit_1_0_la-MIMETypeRegistryGtk.lo :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:

Maybe version of OS is too old, and more recent versions avoid use of ctype? Looks like 10.5 there, I'm seeing the same errors in the log on 10.4.11 "Tiger".

[kitovyj@…]

Yes, my app must be runnable on both Leopard and Snow Leopard, so I have set macosx_deployment_target = 10.5 in macports.conf... Sorry for not mentioning it before. I'll try recompile webkit-gtk with 10.6 deployment target, may be absent images problem is also related with this setting.

Replying to stephen@…:

Replying to kitovyj@…:

But now I'am having another problem : I did "port upgrade outdated", applied your patch and now webkit-gtk does not built at all. Log shows next errors:

:info:build CXX WebCore/platform/gtk/libwebkit_1_0_la-MIMETypeRegistryGtk.lo :info:build /Developer/SDKs/MacOSX10.5.sdk/usr/include/xlocale/_ctype.h:

Maybe version of OS is too old, and more recent versions avoid use of ctype? Looks like 10.5 there, I'm seeing the same errors in the log on 10.4.11 "Tiger".

[elelay (Eric Le Lay)]

for the record, I've built it on Tiger. kitovyj : you said that after an update you couldn't build webkit-gtk anymore. I'll try tonight.

[kitovyj@…]

It seems like the new bug is irrelevant with OS version. I have tried to built webkit-gtk from scratch on 10.6 and got the same messages.

Replying to elelay@…:

for the record, I've built it on Tiger. kitovyj : you said that after an update you couldn't build webkit-gtk anymore. I'll try tonight.

[elelay (Eric Le Lay)]

patch to have compilation working

[elelay (Eric Le Lay)]

here's a new patch to have webkit built, but now (well I'm not sure if it worked before) unicode text display is broken for me (squares everywhere on ​this page).

Replying to kitovyj@…:

It seems like the new bug is irrelevant with OS version. I have tried to built webkit-gtk from scratch on 10.6 and got the same messages.

Replying to elelay@…:

for the record, I've built it on Tiger. kitovyj : you said that after an update you couldn't build webkit-gtk anymore. I'll try tonight.

[elelay (Eric Le Lay)]

Upon closer inspection, it seems to be a font substitution problem (the Arial font that I've got on my computer doesn't have Hebrew but Safari & Firefox are smart enough to use another font), not an encoding problem.

Replying to elelay@…:

here's a new patch to have webkit built, but now (well I'm not sure if it worked before) unicode text display is broken for me (squares everywhere on ​this page).

[elelay (Eric Le Lay)]

it had been reported here : ​https://bugs.webkit.org/show_bug.cgi?id=28727

committed in r68180

[kitovyj@…]

The patch worked for me. However, webkit 1.2.0 still displays black squares instead of images(1.1.15.4 displays images ok) - probably it's the subject for another ticket. Thank you for your help. By the way, does it make sense to try webkit-gtk on top of gtk-osx build from official site : ​http://sourceforge.net/apps/trac/gtk-osx/wiki/Build. Does macports version of gtk +quartz correspond to sourceforge project's version? Sorry for off-topic.

Replying to elelay@…:

it had been reported here : ​https://bugs.webkit.org/show_bug.cgi?id=28727

committed in r68180

[elelay (Eric Le Lay)]

webkit 1.2.1, you mean ?

Another thing you could try if webkit 1.2.1 doesn't work for your app is installing and running midori from macports. If that one works, you do something wrong in your app...

Replying to kitovyj@…:

The patch worked for me. However, webkit 1.2.0 still displays black squares instead of images(1.1.15.4 displays images ok) - probably it's the subject for another ticket. Thank you for your help. By the way, does it make sense to try webkit-gtk on top of gtk-osx build from official site : ​http://sourceforge.net/apps/trac/gtk-osx/wiki/Build. Does macports version of gtk +quartz correspond to sourceforge project's version? Sorry for off-topic.

[cooljeanius (Eric Gallager)]

Cc Me!