ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify

[ryandesign (Ryan Carsten Schmidt)]

I noticed the ice ports (ice-cpp, ice-java, ice-python, ice-python25, ice-python26) are a bit complex in some places and don't take full advantage of the facilities and features MacPorts makes available. I'd like to propose some changes to simplify these ports. I suggest I attach a patch that makes one change to all these ports, explain why I recommend these changes, and once you or I commit it, I'll attach another patch with another proposal.

---

The first suggestion is to make and use a ${branch} variable​, as described in PortfileRecipes. This way you don't have to update the master_sites every time the branch number changes.

[ryandesign (Ryan Carsten Schmidt)]

use ${branch} variable

[blair (Blair Zajac)]

Thanks, applied the branch in r67683.

Next please :)

[ryandesign (Ryan Carsten Schmidt)]

---

Next, simplify the distfiles​. I'd remove setting distfiles and remove the distfile name from inside the checksums definition. You're setting distname, and you only have one distfile, so that's enough.

[ryandesign (Ryan Carsten Schmidt)]

clean up distfiles

[blair (Blair Zajac)]

There was a point when there were separate distfiles, such as Google Protocol Buffer support.

Fixed in r67707 and r67708.

[ryandesign (Ryan Carsten Schmidt)]

---

I'd let MacPorts handle the patch phase​. In ice-cpp and ice-java you override the patch phase and do the patching manually, but it seems to work fine if you just let MacPorts do it. This patch also includes a refresh of ice-cpp's patchfile so it applies without fuzz.

[ryandesign (Ryan Carsten Schmidt)]

patch phase

[blair (Blair Zajac)]

ice-java fixed in r67800 and ice-cpp fixed in r67802.

[ryandesign (Ryan Carsten Schmidt)]

---

Ok, here's a bigger one to make more use of worksrcpath and build.dir​. I see a lot of "${workpath}/Ice-${version}" in these portfiles, and this could be simplified to "${worksrcpath}". And there's several places where you're dealing with a specific subdirectory of ${worksrcpath} -- "cpp" in the ice-cpp port, "java" in the java port, "py" in the python ports -- and this could be further abstracted out into the build.dir variable. This will additionally save you from needing to set test.dir or destroot.dir, since both of those variables' default values is ${build.dir}. And this lets you eliminate some other variables (ice-java and cppdir) which end up being the same as ${build.dir}.

[ryandesign (Ryan Carsten Schmidt)]

use worksrcpath and build.dir variables

[blair (Blair Zajac)]

Thanks! Applied in r67860.

[ryandesign (Ryan Carsten Schmidt)]

---

I'd change the variants​ so all the code relating to the variants is inside the variant declarations. Some disagree, but I find this clearer. The Guide in fact advocates the opposite (advocates doing it the way you already do it in these ports), and this used to be required in older versions of MacPorts, but hasn't been for years, and I no longer recommend it. See #18359.

[ryandesign (Ryan Carsten Schmidt)]

make variants self-contained

[nerdling (Jeremy Lavergne)]

Along these lines, is it handling the architectures properly, either through build.arch or supported_archs?

[cooljeanius (Eric Gallager)]

Cc Me!

[jmroot (Joshua Root)]

These ports have been replaced by zeroc-ice34, zeroc-ice34-java, nothing (ice-python was simply deleted), py25-zeroc-ice, and py26-zeroc-ice, respectively. py*-zeroc-ice were subsequently replaced by py*-zeroc-ice34. You should probably review how much of this is still relevant.

[mf2k (Frank Schima)]

Closing this since none of these ports exist anymore.

$ port list ice-cpp ice-java ice-python ice-python25 ice-python26
$ 

And zeroc-ice34, at least, uses ${branch}.