Brings Pidgin to 2.7.1

[jemaltz@…]

The attached patch brings Pidgin to version 2.7.1. I'm not sure if the default (x11) variant needs/should have modifications, as the gtk docklet code is now in Pidgin-proper (and not applied as a set of patches through the quartz variant).

[ryandesign (Ryan Carsten Schmidt)]

Perhaps finch should be considered at the same time.

[jemaltz@…]

I am willing to submit the updated checksums, and even test a default compile of finch with them, but as I do not actively use it I do not feel that I am the best person to submit that update. This opinion is partially due to, for instance, the update to Pidgin 2.7.0 which broke the +quartz variant.

[nefar@…]

This diff includes the changes made by jemaltz. I've also made a finch variant. It's now possible to install both pidgin and finch with this port by supplying +finch (or only finch by +only_finch)

Quartz compiles, and according to the configure output, is compiled with without-x, however, it starts X11 anyway.

[jemaltz@…]

Replying to nefar@…:

Quartz compiles, and according to the configure output, is compiled with without-x, however, it starts X11 anyway.

What are you referring to here? The patch I posted (and am currently using) does not start X11. I installed pidgin +no_x11 +quartz. I have not tested your update.

[nefar@…]

What are you referring to here? The patch I posted (and am currently using) does not start X11. I installed pidgin +no_x11 +quartz. I have not tested your update.

Would you try mine? Yours starts X11 for me, as does the 2.6.6 version (I just tried it to be sure).

[jemaltz@…]

Replying to nefar@…:

Would you try mine? Yours starts X11 for me, as does the 2.6.6 version (I just tried it to be sure).

Yours does not start X11 for me (I installed +no_x11 +quartz), with some slightly modified ports (necessary as I'm on 64-bit SL), but 2.6.6 and prior versions on my vanilla CD Macbook did not launch X11 either. I actually cannot recall any version of Pidgin via MacPorts that launched X11 (though I can't recall how long I have used it), so I wonder if you are noticing some artifact from previous code.

I also noticed that your patch still modifies some docklet code. Although it did not appear to break anything for me, the unmodified code in 2.7.1 worked as well, so I am curious about the changes (particularly in the .c and .h files).

[nefar@…]

I like keeping things as simple as possible, so I'll put up a new patch file which doesn't include the docklet modifications. I had kept those in there since the previous patch had them.

I do want to get the finch variant in now, so I'll just merge that with yours.

[nefar@…]

OK, removed the docklet mods. Made the quartz option the default. please give it a spin :)

[nefar@…]

OK, removed the docklet mods. Made the quartz option the default. please give it a spin :)

[jemaltz@…]

Replying to nefar@…:

OK, removed the docklet mods. Made the quartz option the default. please give it a spin :)

Installed and loaded successfully here.

[jemaltz@…]

Replying to nefar@…:

OK, removed the docklet mods. Made the quartz option the default. please give it a spin :)

Hm..Tried it on a clean install. Without explicitly specifying +no_x11 +quartz, xorg ports are installed as dependencies.

[jemaltz@…]

(and I would extrapolate to say that the installed ports are probably _not_ the quartz variety...though I did not check this)

[nefar@…]

well, it also installs python and other crap. I'd say it's good to go. It's my experience (coming from FreeBSD ports background) that macports in general installs a lot of redundant ports. Can someone commit?

[jemaltz@…]

I'd hold the commit, so that I can rephrase the behavior :-)

I performed a clean install of MacPorts, and noticed the following:

If one runs sudo port install pidgin, then the +no_x11 +quartz variants of the dependencies are not installed (as far as I can tell), and actually, the x ports/variants (such as the xorg-* ports) are installed as dependencies. I did not complete the installation so I do not know if Pidgin itself is actually installed +no_x11 +quartz, but I suspect it is (or will try to be, but fail) because it is the default variant.

If one instead runs sudo port install pidgin +no_x11 +quartz, then the +no_x11 +quartz variants of the dependencies are definitely installed, and none of the x ports/variants (including xorg-*) are installed as dependencies, and Pidgin successfully installs/runs.

In other words, the default variant behavior is not working correctly, at least when it comes to the dependencies.

Also, another bit of interetesting behavior: The dependencies for sudo port install pidgin +quartz are slightly different from the dependencies of sudo port install pidgin +no_x11 +quartz, despite the +quartz variant requiring +no_x11.

It sounds like this little exercise may have uncovered some bugs in MacPorts. I'm curious to hear the developers' opinions about this.

@nefar - For now, this might be the case of trying to do too much in a single commit. It may be worth submitting two patches while the above gets worked out: First, upgrade Pidgin (and Finch) to 2.7.1, then merge Pidgin and Finch. Once more info is known about what's happening on this ticket (and how to get the expected behavior), then +quartz can be made the default variant.

[nefar@…]

I'm not sure why the merging of finch needs to be taken out. Seems the only problem is the default being +quartz. IOW, the only thing I should take out is the default_variants +quartz.

Agreed, or am I missing something else?

[jemaltz@…]

I agree. I only suggested splitting up the patches in order to keep track of what was happening. Now that I've found out more about default variants, I think it is sufficient to push the merged patch (without the default variant set to +quartz).

[nefar@…]

without quartz as default

[nefar@…]

ok, latest diff is without quartz as default as discussed

[nefar@…]

can someone commit please?

[raimue (Rainer Müller)]

Committed in r69627.

[jemaltz@…]

Replying to nefar@…:

can someone commit please?

Something should probably be done about the Finch port. I am not sure how something like upgrading the Finch port to a Finch variant of the Pidgin port would be done, and if the Finch port is simply removed (probably the best option), how will the users find out about the change in port management (specifically that the Finch port has not been removed, it has just been merged with another)?

[jmroot (Joshua Root)]

Closing per maintainer's request.