#25262 closed defect (fixed)
openload: patch to fix compile issue in snow leopard
| Reported by: | smibrahim@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.0 |
| Keywords: | maintainer haspatch | Cc: | |
| Port: | openload |
Description
someone please commit the attached portfile and patch file for port openload
Attachments (2)
Change History (5)
Changed 14 years ago by smibrahim@…
Changed 14 years ago by smibrahim@…
| Attachment: | patch-src-tmplchunk.h.diff added |
|---|
comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
| Summary: | patch to fix openload compile issue in snow leopard → openload: patch to fix compile issue in snow leopard |
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | maintainer haspatch added |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Committed in r68834. In the future please submit unified diffs, not complete portfiles, so we can better evaluate your proposed changes.
Your new portfile appears to be based on the version you originally submitted in #19363 and not the version that got committed to the repository. Your new portfile did not include the post-destroot section currently in the port that installs the documentation files, and it did include --bindir and --mandir configure args that are not necessary and never got committed before. Bryan explained in #19363 why these changes were made and you agreed to them. You should always base your diffs on the version currently in the repository.
I was unable to locate any distfile for an openload 0.1.2.1. Since you did not change the checksums, I assumed you meant to keep the version at 0.1.2 but increase the revision to 1. This also suggests to me you did not test this modification before submitting it here. Please test your modifications in the future before submitting.
portfile