xfig-3.2.5 does not recognize special characters

[lawrence.ong@…]

When exporting to all three: PostScript, PDF and TeX, using File > Export > Combined PS/PDF/LaTeX, xfig incorrectly generates PostScript and PDF that included LaTeX-only (special) text

Steps to Reproduce:

1. Open a new figure in xfig, draw a circle.
2. Select T (text) input on the left menu, on the bottom row click on Text Flags and select Special Flag to Special.
3. Click somewhere in the circle and type $\pi$
4. Save figure as toto.fig, then go to File > Export > Combined PS/PDF/LaTeX. The generated files toto_pspdftex.eps and toto_pspdftex.pdf should contain just the circle, but they also contain $\pi$. The third file: toto.pspdftex is correct.

This is a known problem and has been resolved. See bugs fixed for Patchlevel 5a: ​http://www.xfig.org/art17.html

But the version in MacPorts still has this problem.

[lawrence.ong@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Remember to use WikiFormatting.

Note you don't need to Cc yourself.

Thank you for the reproduction recipe.

This ticket might be considered a duplicate of #22967.

[sewebster@…]

Definitely looks like a duplicate, we just need to update xfig to the latest 5b. Lawrence, if you are keen this might be a good opportunity to produce a patch to the Portfile. I think you probably just need to add a "b" to the end of the version, remove the revision line and update the checksums.

[lawrence.ong@…]

patch for Portfile

[lawrence.ong@…]

Replying to sewebster@…:

Definitely looks like a duplicate, we just need to update xfig to the latest 5b. Lawrence, if you are keen this might be a good opportunity to produce a patch to the Portfile. I think you probably just need to add a "b" to the end of the version, remove the revision line and update the checksums.

I have created patch files for xfig version 3.2.5b.

[sewebster@…]

Cool... but I am a little bit confused. The xfig people are distributing a new distfile that includes the up to date version 5b right? Are all your patch files (except the Portfile patch) just to make the changes that are in the new 5b distfile? If so, then I don't think we need those, we just need to update the Portfile, and macports will "automatically" know to download the new distfile and build xfig. Sorry if I caused you to do extra work, or if I'm the one who is confused and your patches are necessary for some reason.

In any event, we need to get someone with commit access to apply the Portfile patch if that is all that is required. Your Portfile patch looks good to me, but I haven't tested it.

[lawrence.ong@…]

Actually those patch files were to be applied to the new distfile in version 5b. I looked into the patches for version 5, and realised that the changes were not reflected in version 5b. So, I presumed that they will be needed for the new version as well.

[sewebster@…]

Ah, I see. That is seems odd that they would release a new distfile without all the latest patches applied!

[sewebster@…]

So if we need to apply all those patches, then the Portfile needs to contain the instructions to apply the patches too. There should be instructions about doing this in the guide. The port already has patches, and some of them are to the same files, so maybe they are the same patches? If not, then I guess they need to be merged together... Normally you might want to get some confirmation from the maintainer on this sort of thing before doing a bunch of work, but this port has no maintainer, so you're kinda stuck waiting until someone comes along who can fix things up.

[lawrence.ong@…]

Replying to sewebster@…:

Ah, I see. That is seems odd that they would release a new distfile without all the latest patches applied!

I am not sure if those patches are specific to Macports.

[lawrence.ong@…]

Replying to sewebster@…:

So if we need to apply all those patches, then the Portfile needs to contain the instructions to apply the patches too. There should be instructions about doing this in the guide. The port already has patches, and some of them are to the same files, so maybe they are the same patches? If not, then I guess they need to be merged together... Normally you might want to get some confirmation from the maintainer on this sort of thing before doing a bunch of work, but this port has no maintainer, so you're kinda stuck waiting until someone comes along who can fix things up.

Yes, they are the same patches as those in version 5. So, they are already listed in the Portfile. As there is no maintainer for this port, is there anything we can do at this point?

[sewebster@…]

Did you test your patch to the Portfile and confirm that everything works if you run "sudo port upgrade xfig"? If so, perhaps Ryan can commit the update (he is on the cc list for this ticket).

[lawrence.ong@…]

I have successfully tested the patched Portfile and compiled xfig version 3.2.5b with the attached source patches. Everything is working file. It indeed fixed the problem reported in this ticket.

[sewebster@…]

Cc Me!

[lawrence.ong@…]

Ryan, could you help to update the port?

[ryandesign (Ryan Carsten Schmidt)]

I updated the port using my own patches in r70347. Does this help?

[ryandesign (Ryan Carsten Schmidt)]

Fixed a few other problems in subsequent revisions and xfig @3.2.5b_2 seems to not have the problem originally described in this ticket so I think we're fixed.

[lawrence.ong@…]

Ryan, thanks for the update. I confirm that the problem described in this ticket is fixed in version 3.2.5b_2.