Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#25658 closed submission (fixed)

New port: sbt

Reported by: lists@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc:
Port: sbt

Description (last modified by ryandesign (Ryan Carsten Schmidt))

I am attaching a Portfile and file, sbt.sh, for the simple-build-tool (sbt) project.

Attachments (2)

Portfile (1.8 KB) - added by lists@… 14 years ago.
sbt Portfile
sbt.sh (1016 bytes) - added by lists@… 14 years ago.
files/sbt.sh

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by lists@…

Attachment: Portfile added

sbt Portfile

Changed 14 years ago by lists@…

Attachment: sbt.sh added

files/sbt.sh

comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thanks, committed in r69713 with these changes:

  • changed whitespace from a mixture of spaces and tabs to all spaces
  • did reinplacing in post-patch instead of in configure; it was contradictory to both have a configure phase and to say "use_configure no"
  • removed "universal_variant no" since it is implied by "use_configure no"
  • removed comment for local variable project_name and moved this variable closer to where it's used
  • moved distname closer to master_sites
  • added "supported_archs noarch" since this port installs no architecture-specific files
  • removed unnecessary quotes around things
  • removed the comment about symlinking, and used built-in "ln" command to make the symlink instead of calling out to the shell with "system"

comment:3 Changed 14 years ago by lists@…

I much appreciate the detailed comments on the changes. Your comments answered a few questions I was unable to find in the docs.

Note: See TracTickets for help on using tickets.